-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_gateway: test account tx in mempool influence on validation #9950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11-04-apollo_gateway_extract_async_mempool_query_from_blocking_task
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Is that arrow symbol standard ASCII? I assume not. Please refrain from using it if this is the case. Suggestion: account tx in mempool -> skip validation |
7faf351 to
f8cf519
Compare
d139542 to
f535c85
Compare
f535c85 to
a31bc96
Compare
f8cf519 to
c51f57e
Compare
a31bc96 to
9fa4f2f
Compare
c51f57e to
d2d5f77
Compare
d2d5f77 to
e827b03
Compare
6d21bf3 to
ecc9ac9
Compare
e827b03 to
14142cc
Compare
ecc9ac9 to
15c1729
Compare
90e1beb to
ba27508
Compare
15c1729 to
60beac9
Compare
60beac9 to
b45425c
Compare
ba27508 to
a9b8430
Compare
b45425c to
bbbcefb
Compare
a1ef90a to
fc642eb
Compare
bbbcefb to
34d8704
Compare
fc642eb to
b4115d2
Compare
34d8704 to
40cf6e3
Compare

TL;DR
Added a test to verify that validation is skipped for account transactions already in the mempool.
What changed?
Added a new test case
test_account_tx_in_mempool_influence_on_validationthat verifies the behavior of transaction validation based on whether an account transaction is already in the mempool. The test covers three scenarios:How to test?
Run the new test with:
cargo test -p apollo_gateway test_account_tx_in_mempool_influence_on_validationWhy make this change?
This test ensures that the stateful transaction validator correctly optimizes validation by skipping redundant validation for transactions already present in the mempool, while still properly validating transactions that aren't in the mempool or when mempool errors occur.