-
Notifications
You must be signed in to change notification settings - Fork 699
refactor: rename &T from references -> repr_ptrs #8612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename &T from references -> repr_ptrs #8612
Conversation
48ce0c0 to
496eaf1
Compare
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @TomerStarkware)
crates/cairo-lang-semantic/src/items/tests/type_mismatch_diagnostics line 282 at r1 (raw file):
//! > expected_diagnostics error: Cannot assign to a pointed-to variable
or something?
Suggestion:
error: Cannot assign to a variable with a taken pointer
crates/cairo-lang-semantic/src/expr/compute.rs line 513 at r1 (raw file):
if let Some(&referenced_at) = self.referenced_mut_vars.get(var_id) { let note = DiagnosticNote::with_location( "variable pointed to here".into(),
Suggestion:
"variable pointer taken here".into(),
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase and @TomerStarkware)
496eaf1 to
52b6b2d
Compare
giladchase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi and @TomerStarkware)
crates/cairo-lang-semantic/src/items/tests/type_mismatch_diagnostics line 282 at r1 (raw file):
Previously, orizi wrote…
or something?
Done.
giladchase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 9 of 13 files reviewed, 2 unresolved discussions (waiting on @orizi and @TomerStarkware)
crates/cairo-lang-semantic/src/expr/compute.rs line 513 at r1 (raw file):
if let Some(&referenced_at) = self.referenced_mut_vars.get(var_id) { let note = DiagnosticNote::with_location( "variable pointed to here".into(),
Done.
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
52b6b2d to
49033d0
Compare
d9d6961 to
2084647
Compare
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
2084647 to
0775fbd
Compare
49033d0 to
b4cd383
Compare
Merge activity
|
TomerStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomerStarkware reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)

No description provided.