Skip to content

Conversation

@giladchase
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@giladchase giladchase force-pushed the gilad/11-05-refactor_rename_t_from_references_-_repr_ptrs branch from 48ce0c0 to 496eaf1 Compare November 5, 2025 15:13
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @TomerStarkware)


crates/cairo-lang-semantic/src/items/tests/type_mismatch_diagnostics line 282 at r1 (raw file):


//! > expected_diagnostics
error: Cannot assign to a pointed-to variable

or something?

Suggestion:

error: Cannot assign to a variable with a taken pointer

crates/cairo-lang-semantic/src/expr/compute.rs line 513 at r1 (raw file):

        if let Some(&referenced_at) = self.referenced_mut_vars.get(var_id) {
            let note = DiagnosticNote::with_location(
                "variable pointed to here".into(),

Suggestion:

                "variable pointer taken here".into(),

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase and @TomerStarkware)

@giladchase giladchase force-pushed the gilad/11-05-refactor_rename_t_from_references_-_repr_ptrs branch from 496eaf1 to 52b6b2d Compare November 6, 2025 04:13
Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi and @TomerStarkware)


crates/cairo-lang-semantic/src/items/tests/type_mismatch_diagnostics line 282 at r1 (raw file):

Previously, orizi wrote…

or something?

Done.

Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 9 of 13 files reviewed, 2 unresolved discussions (waiting on @orizi and @TomerStarkware)


crates/cairo-lang-semantic/src/expr/compute.rs line 513 at r1 (raw file):

        if let Some(&referenced_at) = self.referenced_mut_vars.get(var_id) {
            let note = DiagnosticNote::with_location(
                "variable pointed to here".into(),

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

@giladchase giladchase force-pushed the gilad/11-05-refactor_rename_t_from_references_-_repr_ptrs branch from 52b6b2d to 49033d0 Compare November 6, 2025 13:38
@giladchase giladchase force-pushed the gilad/11-05-feat_lowering_add_lowering_tests_for_experimental_t_support branch from d9d6961 to 2084647 Compare November 6, 2025 13:38
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

@graphite-app graphite-app bot changed the base branch from gilad/11-05-feat_lowering_add_lowering_tests_for_experimental_t_support to graphite-base/8612 November 9, 2025 07:24
@giladchase giladchase force-pushed the gilad/11-05-refactor_rename_t_from_references_-_repr_ptrs branch from 49033d0 to b4cd383 Compare November 9, 2025 08:20
@graphite-app graphite-app bot changed the base branch from graphite-base/8612 to main November 9, 2025 08:21
@graphite-app
Copy link

graphite-app bot commented Nov 9, 2025

Merge activity

  • Nov 9, 8:21 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@TomerStarkware reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase added this pull request to the merge queue Nov 9, 2025
Merged via the queue into main with commit e4f6ead Nov 9, 2025
106 checks passed
@orizi orizi deleted the gilad/11-05-refactor_rename_t_from_references_-_repr_ptrs branch November 9, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants