feat(lowering): add lowering tests for experimental &T support #8610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2025
|
This change is |
This was referenced Nov 5, 2025
Contributor
Author
orizi
approved these changes
Nov 5, 2025
Collaborator
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
giladchase
force-pushed
the
gilad/11-05-feat_lowering_add_lowering_tests_for_experimental_t_support
branch
from
2ea717c to
d9d6961
Compare
orizi
approved these changes
Nov 5, 2025
Collaborator
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
giladchase
force-pushed
the
gilad/11-04-fix_parser_better_handling_for_multi-reference_objects_t_t_etc_
branch
from
d332f5a to
c22deda
Compare
giladchase
force-pushed
the
gilad/11-05-feat_lowering_add_lowering_tests_for_experimental_t_support
branch
from
d9d6961 to
2084647
Compare
giladchase
changed the base branch from
gilad/11-04-fix_parser_better_handling_for_multi-reference_objects_t_t_etc_
to
graphite-base/8610
Lowering logic didn't change since &T is de-sugared into Box(@t) in the semantic stage.
giladchase
force-pushed
the
graphite-base/8610
branch
from
c22deda to
f66ac28
Compare
giladchase
force-pushed
the
gilad/11-05-feat_lowering_add_lowering_tests_for_experimental_t_support
branch
from
2084647 to
6ec44f0
Compare
Merge activity
|
orizi
deleted the
gilad/11-05-feat_lowering_add_lowering_tests_for_experimental_t_support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering logic didn't change since &T is de-sugared into Box(@t) in the
semantic stage.