fix: show errors when running a detached process #940
Conversation
There was a problem hiding this comment.
I see the error happening now for example if I run with a bad secret key reference. But It's a simple text output, doesn't have the same format as other log output, should we be expecting a red ERR level? Here's full output:
./bin/thv run --secret badsecretkey,target=GITHUB_PERSONAL_ACCESS_TOKEN github
A new version of ToolHive is available: v0.1.2
Currently running: v0.1.2-5-g0e353a0
3:12PM INF MCP server ghcr.io/github/github-mcp-server:latest is verified successfully
3:12PM INF Image ghcr.io/github/github-mcp-server:latest has 'latest' tag, pulling to ensure we have the most recent version...
3:12PM INF Pulling image: ghcr.io/github/github-mcp-server:latest
Pulling from github/github-mcp-server: latest
Digest: sha256:db17de30c03103dd8b40ba63686a899270a79a1487d2304db0314e5c716118cf
Status: Image is up to date for ghcr.io/github/github-mcp-server:latest
3:12PM INF Successfully pulled image: ghcr.io/github/github-mcp-server:latest
3:12PM INF Logging to: /Users/dan/Library/Application Support/toolhive/logs/github.log
Error: startup error (PID 57967): A new version of ToolHive is available: v0.1.2
Currently running: v0.1.2-5-g0e353a0
3:12PM WRN MCP server ghcr.io/github/github-mcp-server:latest has no provenance information set, skipping image verification
3:12PM INF Image ghcr.io/github/github-mcp-server:latest has 'latest' tag, pulling to ensure we have the most recent version...
3:12PM INF Pulling image: ghcr.io/github/github-mcp-server:latest
3:12PM INF Successfully pulled image: ghcr.io/github/github-mcp-server:latest
3:12PM INF OIDC validation disabled, using local user authentication
3:12PM INF Using local user authentication for user: dan
3:12PM INF MCP parsing middleware enabled for transport
3:12PM INF Saved run configuration for github
Error: failed to get secrets: secret not found: badsecretkey
Well, it's because those logs are not part of the flow itself, but come from the container. But i'll see if i can format them better. |
This was raised by this issue, but is a common problem, when toolhive is run in detached mode, all the errors are masked, only can be seen in foreground. This PR populates error logs in detached mode, so problems are visible to the end user Closes: #704
| return | ||
| } | ||
| // Print the log file contents | ||
| // This is done in a deferred function to ensure it runs after the log file is closed |
There was a problem hiding this comment.
Is the log file not closed in the block above?
I thought about it. But is true that generally, we are informing to the user about "MCP server is up and running" when it's not the case. So this PR corrects it. I could do another for the checks, but i thought this could be useful as well. At a minimum, remove the sentence of "MCP server is up and running" because it's confusing and we are not informing the user correctly. So we either show the logs here, or rephrase the sentence telling "MCP server deployment process has finished. Please check logs to get the status" or something around those lines |
This was raised by this issue, but is a common problem, when toolhive is run in detached mode, all the errors are masked, only can be seen in foreground.
This PR populates error logs in detached mode, so problems are visible to the end user
Closes: #704