fix: show errors when running a detached process

cmd/thv/app/run.go

@@ -346,7 +346,11 @@ func runCmdFunc(cmd *cobra.Command, args []string) error {
 	if runForeground {
 		return workloadManager.RunWorkload(ctx, runConfig)
 	}
-	return workloadManager.RunWorkloadDetached(runConfig)
+	err = workloadManager.RunWorkloadDetached(runConfig)
+	if err != nil {
+		return fmt.Errorf("failed to run MCP workload detached: %v", err)
+	}
+	return nil
 }
 
 // parseCommandArguments processes command-line arguments to find everything after the -- separator

pkg/transport/proxy/transparent/transparent_proxy.go

@@ -148,9 +148,12 @@ func (p *TransparentProxy) Start(ctx context.Context) error {
 }
 
 func (p *TransparentProxy) monitorHealth(parentCtx context.Context) {
-	ticker := time.NewTicker(10 * time.Second)
+	ticker := time.NewTicker(30 * time.Second)
 	defer ticker.Stop()
 
+	var failCount int
+	const maxFails = 5
+
 	for {
 		select {
 		case <-parentCtx.Done():
@@ -162,11 +165,20 @@ func (p *TransparentProxy) monitorHealth(parentCtx context.Context) {
 		case <-ticker.C:
 			alive := p.healthChecker.CheckHealth(parentCtx)
 			if alive.Status != healthcheck.StatusHealthy {
-				logger.Infof("Health check failed for %s; initiating proxy shutdown", p.containerName)
-				if err := p.Stop(parentCtx); err != nil {
-					logger.Errorf("Failed to stop proxy for %s: %v", p.containerName, err)
+				failCount++
+				if failCount >= maxFails {
+					logger.Infof("Health check failed %d times; shutting down proxy for %s", maxFails, p.containerName)
+					if err := p.Stop(parentCtx); err != nil {
+						logger.Errorf("Failed to stop proxy for %s: %v", p.containerName, err)
+					}
+					return
+				}
+			} else {
+				// Reset counter on success
+				if failCount > 0 {
+					logger.Infof("Health check recovered for %s; resetting failure counter", p.containerName)
 				}
-				return
+				failCount = 0
 			}
 		}
 	}

pkg/workloads/manager.go

@@ -188,8 +188,28 @@ func (*defaultManager) RunWorkloadDetached(runConfig *runner.RunConfig) error {
 	if err != nil {
 		logger.Warnf("Warning: Failed to create log file: %v", err)
 	} else {
-		defer logFile.Close()
-		logger.Infof("Logging to: %s", logFilePath)
+		defer func() {
+			// Read and print the log file contents when closing
+			if err := logFile.Close(); err != nil {
+				logger.Warnf("Warning: failed to close log file: %v", err)
+				return
+			}
+			// Print the log file contents
+			// This is done in a deferred function to ensure it runs after the log file is closed
+			defer func() {
+				// print the log file contents
+				data, err := os.ReadFile(logFilePath) // #nosec G304 - This is safe as logFilePath is controlled by the application
+				if err != nil {
+					logger.Warnf("Warning: failed to read log file: %v", err)
+					return
+				}
+				fmt.Println("\n\n=== Log file contents ===")
+				fmt.Print(string(data))
+				fmt.Println("=== End of log file ===")
+			}()
+		}()
+		logger.Infof("Logging to: %s - Please check log for more information about process success", logFilePath)
+
 	}
 
 	// Prepare the command arguments for the detached process
@@ -368,9 +388,6 @@ func (*defaultManager) RunWorkloadDetached(runConfig *runner.RunConfig) error {
 		logger.Warnf("Warning: Failed to write PID file: %v", err)
 	}
 
-	logger.Infof("MCP server is running in the background (PID: %d)", detachedCmd.Process.Pid)
-	logger.Infof("Use 'thv stop %s' to stop the server", runConfig.ContainerName)
-
 	return nil
 }
 

test/e2e/proxy_oauth_test.go

@@ -443,7 +443,7 @@ var _ = Describe("Proxy OAuth Authentication E2E", Serial, func() {
 
 			By("Reconnecting via MCP to trigger token refresh")
 			proxyURL := fmt.Sprintf("http://localhost:%d/sse", proxyPort)
-			err = e2e.WaitForMCPServerReady(config, proxyURL, "sse", 10*time.Second)
+			err = e2e.WaitForMCPServerReady(config, proxyURL, "sse", 30*time.Second)
 			Expect(err).ToNot(HaveOccurred(), "MCP server not ready after token expiry")
 
 			mcpClient, err := e2e.NewMCPClientForSSE(config, proxyURL)