Skip to content

Refactor AIO script and fix for Epoxy #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: stackhpc/2025.1
Choose a base branch
from
Open

Conversation

Alex-Welsh
Copy link
Member

No description provided.

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner June 12, 2025 14:01
@product-auto-label product-auto-label bot added size: l documentation Improvements or additions to documentation labels Jun 12, 2025
@Alex-Welsh
Copy link
Member Author

I'd like to remove the "manual setup" section of the docs. It's duplicated effort trying to maintain two versions (script and docs). There's a few useful bits at the bottom about Ironic testing and Tenks, but I don't think they're tested/maintained well.

Any objections?

@Alex-Welsh
Copy link
Member Author

CI error can be ignored. Known upstream issue, should be fixed soonish

seunghun1ee
seunghun1ee previously approved these changes Jun 16, 2025
@MoteHue
Copy link
Contributor

MoteHue commented Aug 8, 2025

I'd like to remove the "manual setup" section of the docs. It's duplicated effort trying to maintain two versions (script and docs). There's a few useful bits at the bottom about Ironic testing and Tenks, but I don't think they're tested/maintained well.

Any objections?

I think it's worth keeping the testing section, but I don't really see a reason to keep the setup instructions. I'd imagine everyone just uses the script.

Copy link
Contributor

@MoteHue MoteHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I've tested the script myself, not found any glaring issues. Just have a couple of improvements to suggest

export KAYOBE_VAULT_PASSWORD
pushd "$BASE_PATH/src/kayobe-config"
source kayobe-env --environment ci-aio
source $BASE_PATH/venvs/kayobe/bin/activate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be good to add kayobe autocompletion here too, like we do in beokay env-vars. Just to test that activating autocompletion works.

Suggested change
source $BASE_PATH/venvs/kayobe/bin/activate
source $BASE_PATH/venvs/kayobe/bin/activate
source <(kayobe complete)

Could be even better to test using beokay in this script, but that's scope creep for this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not a fan of kayobe complete. It doesn't behave properly when you try to reference file paths. I'd prefer to leave it disabled for now. If we edit the script further in the future to use beokay then you'll probably get your wish then anyway.

Like you say, adding beokay would be a bit out of scope for this change. Not opposed to adding it in the future though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size: l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants