-
Notifications
You must be signed in to change notification settings - Fork 23
Refactor AIO script and fix for Epoxy #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
I'd like to remove the "manual setup" section of the docs. It's duplicated effort trying to maintain two versions (script and docs). There's a few useful bits at the bottom about Ironic testing and Tenks, but I don't think they're tested/maintained well. Any objections? |
CI error can be ignored. Known upstream issue, should be fixed soonish |
I think it's worth keeping the testing section, but I don't really see a reason to keep the setup instructions. I'd imagine everyone just uses the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I've tested the script myself, not found any glaring issues. Just have a couple of improvements to suggest
export KAYOBE_VAULT_PASSWORD | ||
pushd "$BASE_PATH/src/kayobe-config" | ||
source kayobe-env --environment ci-aio | ||
source $BASE_PATH/venvs/kayobe/bin/activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be good to add kayobe autocompletion here too, like we do in beokay env-vars. Just to test that activating autocompletion works.
source $BASE_PATH/venvs/kayobe/bin/activate | |
source $BASE_PATH/venvs/kayobe/bin/activate | |
source <(kayobe complete) |
Could be even better to test using beokay in this script, but that's scope creep for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally not a fan of kayobe complete. It doesn't behave properly when you try to reference file paths. I'd prefer to leave it disabled for now. If we edit the script further in the future to use beokay then you'll probably get your wish then anyway.
Like you say, adding beokay would be a bit out of scope for this change. Not opposed to adding it in the future though.
No description provided.