Skip to content

Fix negated integer literals with aliases in EXPLAIN output #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 1 commit into from
Dec 30, 2025
Merged

Fix negated integer literals with aliases in EXPLAIN output #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions internal/explain/expressions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,22 +418,19 @@ func explainAliasedExpr(sb *strings.Builder, n *ast.AliasedExpr, depth int) {
}
case *ast.UnaryExpr:
// Handle negated numeric literals - output as Literal instead of Function negate
// For integers, only do this in subquery context (ClickHouse behavior)
// For floats (especially inf/nan), always do this
// When an aliased expression is a negated literal, output as negative Literal
if e.Op == "-" {
if lit, ok := e.Operand.(*ast.Literal); ok {
switch lit.Type {
case ast.LiteralInteger:
// Only convert to literal in subquery context
if inSubqueryContext {
switch val := lit.Value.(type) {
case int64:
fmt.Fprintf(sb, "%sLiteral Int64_%d (alias %s)\n", indent, -val, escapeAlias(n.Alias))
return
case uint64:
fmt.Fprintf(sb, "%sLiteral Int64_-%d (alias %s)\n", indent, val, escapeAlias(n.Alias))
return
}
// Convert negated integer to negative literal
switch val := lit.Value.(type) {
case int64:
fmt.Fprintf(sb, "%sLiteral Int64_%d (alias %s)\n", indent, -val, escapeAlias(n.Alias))
return
case uint64:
fmt.Fprintf(sb, "%sLiteral Int64_-%d (alias %s)\n", indent, val, escapeAlias(n.Alias))
return
}
case ast.LiteralFloat:
// Always convert negated floats to literals (especially for -inf, -nan)
Expand Down