Fix negated integer literals with aliases in EXPLAIN output #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the subquery context restriction when outputting negated integer literals with aliases. Previously, `-5 as offset` was incorrectly rendered as `Function negate (alias offset)` in regular SELECT statements, but should be rendered as `Literal Int64_-5 (alias offset)`. This fixes several failing tests in the 02154_bit_slice_for_string and 02154_bit_slice_for_fixedstring test suites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the subquery context restriction when outputting negated integer
literals with aliases. Previously,
-5 as offsetwas incorrectly renderedas
Function negate (alias offset)in regular SELECT statements, but shouldbe rendered as
Literal Int64_-5 (alias offset).This fixes several failing tests in the 02154_bit_slice_for_string and
02154_bit_slice_for_fixedstring test suites.