Fix SETTINGS placement in EXPLAIN output based on SettingsAfterFormat #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SETTINGS comes before FORMAT in a query, it should be output inside SelectQuery. When SETTINGS comes after FORMAT, it should be output at the SelectWithUnionQuery level. This fixes ~58 tests that had incorrect SETTINGS placement in their EXPLAIN AST output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SETTINGS comes before FORMAT in a query, it should be output
inside SelectQuery. When SETTINGS comes after FORMAT, it should be
output at the SelectWithUnionQuery level.
This fixes ~58 tests that had incorrect SETTINGS placement in their
EXPLAIN AST output.