Skip to content

CC-36553: Refactor service point list item retrieval to improve the test reliablility. #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

CC-36553: Refactor service point list item retrieval to improve the test reliablility. #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cypress/support/pages/yves/product/repositories/b2b-mp-product-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { injectable } from 'inversify';
import { ProductRepository } from '../product-repository';
import * as Cypress from 'cypress';

@injectable()
export class B2bMpProductRepository implements ProductRepository {
Expand All @@ -26,7 +25,10 @@ export class B2bMpProductRepository implements ProductRepository {
getAssetOptions = (): Cypress.Chainable => cy.get('[data-qa="asset-option-trigger"');
getServicePointSearchInput = (): Cypress.Chainable => cy.get('[data-qa="component ssp-service-point-finder"] input');
getServicePointListItem = (servicePointName: string): Cypress.Chainable =>
cy.contains('[data-qa="component service-point"]', servicePointName).find('button');
cy
.get('[data-qa="component service-point"]')
.filter((_, el) => Cypress.$(el).find('.service-point__name').text().trim() === servicePointName)
.find('button');
getSelectedServicePointName = (): Cypress.Chainable => cy.get('[data-qa="component ssp-service-point-selector"]');
getCloseServicePointPopupButton = (): Cypress.Chainable => cy.get('.js-main-popup__close');
getSspAssetNameBlock = (): Cypress.Chainable => cy.get('[data-qa="asset-selector-name"]');
Expand Down
6 changes: 4 additions & 2 deletions cypress/support/pages/yves/product/repositories/b2b-product-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { injectable } from 'inversify';
import { ProductRepository } from '../product-repository';
import * as Cypress from 'cypress';

@injectable()
export class B2bProductRepository implements ProductRepository {
Expand All @@ -23,7 +22,10 @@ export class B2bProductRepository implements ProductRepository {
cy.get('[data-qa="component ssp-service-point-selector"] button');
getServicePointSearchInput = (): Cypress.Chainable => cy.get('[data-qa="component ssp-service-point-finder"] input');
getServicePointListItem = (servicePointName: string): Cypress.Chainable =>
cy.contains('[data-qa="component service-point"]', servicePointName).find('button');
cy
.get('[data-qa="component service-point"]')
.filter((_, el) => Cypress.$(el).find('.service-point__name').text().trim() === servicePointName)
.find('button');
getSelectAssetButton = (): Cypress.Chainable => cy.get('[data-qa="asset-selector-trigger"]');
getSelectAssetPopup = (): Cypress.Chainable => cy.get('[data-qa="asset-selector-results"]', { timeout: 10000 });
getAssetOptions = (): Cypress.Chainable => cy.get('[data-qa="asset-option-trigger"');
Expand Down
6 changes: 4 additions & 2 deletions cypress/support/pages/yves/product/repositories/b2c-mp-product-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { injectable } from 'inversify';
import { ProductRepository } from '../product-repository';
import * as Cypress from 'cypress';

@injectable()
export class B2cMpProductRepository implements ProductRepository {
Expand All @@ -26,7 +25,10 @@ export class B2cMpProductRepository implements ProductRepository {
getAssetOptions = (): Cypress.Chainable => cy.get('[data-qa="asset-option-trigger"');
getServicePointSearchInput = (): Cypress.Chainable => cy.get('[data-qa="component ssp-service-point-finder"] input');
getServicePointListItem = (servicePointName: string): Cypress.Chainable =>
cy.contains('[data-qa="component service-point"]', servicePointName).find('button');
cy
.get('[data-qa="component service-point"]')
.filter((_, el) => Cypress.$(el).find('.service-point__name').text().trim() === servicePointName)
.find('button');
getSelectedServicePointName = (): Cypress.Chainable => cy.get('[data-qa="component ssp-service-point-selector"]');
getCloseServicePointPopupButton = (): Cypress.Chainable => cy.get('.js-main-popup__close');
getSspAssetNameBlock = (): Cypress.Chainable => cy.get('[data-qa="asset-selector-name"]');
Expand Down
6 changes: 4 additions & 2 deletions cypress/support/pages/yves/product/repositories/b2c-product-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { injectable } from 'inversify';
import { ProductRepository } from '../product-repository';
import * as Cypress from 'cypress';

@injectable()
export class B2cProductRepository implements ProductRepository {
Expand All @@ -26,7 +25,10 @@ export class B2cProductRepository implements ProductRepository {
getAssetOptions = (): Cypress.Chainable => cy.get('[data-qa="asset-option-trigger"');
getServicePointSearchInput = (): Cypress.Chainable => cy.get('[data-qa="component ssp-service-point-finder"] input');
getServicePointListItem = (servicePointName: string): Cypress.Chainable =>
cy.contains('[data-qa="component service-point"]', servicePointName).find('button');
cy
.get('[data-qa="component service-point"]')
.filter((_, el) => Cypress.$(el).find('.service-point__name').text().trim() === servicePointName)
.find('button');
getSelectedServicePointName = (): Cypress.Chainable => cy.get('[data-qa="component ssp-service-point-selector"]');
getCloseServicePointPopupButton = (): Cypress.Chainable => cy.get('.js-main-popup__close');
getSspAssetNameBlock = (): Cypress.Chainable => cy.get('[data-qa="asset-selector-name"]');
Expand Down
6 changes: 4 additions & 2 deletions cypress/support/pages/yves/product/repositories/suite-product-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { injectable } from 'inversify';
import { ProductRepository } from '../product-repository';
import * as Cypress from 'cypress';

@injectable()
export class SuiteProductRepository implements ProductRepository {
Expand All @@ -26,7 +25,10 @@ export class SuiteProductRepository implements ProductRepository {
getSelectAssetPopup = (): Cypress.Chainable => cy.get('[data-qa="asset-selector-results"]', { timeout: 10000 });
getAssetOptions = (): Cypress.Chainable => cy.get('[data-qa="asset-option-trigger"');
getServicePointListItem = (servicePointName: string): Cypress.Chainable =>
cy.contains('[data-qa="component service-point"]', servicePointName).find('button');
cy
.get('[data-qa="component service-point"]')
.filter((_, el) => Cypress.$(el).find('.service-point__name').text().trim() === servicePointName)
.find('button');
getSelectedServicePointName = (): Cypress.Chainable => cy.get('[data-qa="component ssp-service-point-selector"]');
getCloseServicePointPopupButton = (): Cypress.Chainable => cy.get('.js-main-popup__close');
getSspAssetNameBlock = (): Cypress.Chainable => cy.get('[data-qa="asset-selector-name"]');
Expand Down