Skip to content

Conversation

@abitskil
Copy link
Collaborator

@abitskil abitskil commented Nov 7, 2025

PR Description

Task: https://spryker.atlassian.net/browse/CC-36553

This pull request refactors how service point list items are selected in several Cypress product repository classes to improve accuracy and reliability. Instead of using a text-based search, it now filters DOM elements to match the exact service point name. Additionally, unused imports of Cypress types are removed from each repository file.

Test selector improvements:

  • The getServicePointListItem method in B2bMpProductRepository, B2bProductRepository, B2cMpProductRepository, B2cProductRepository, and SuiteProductRepository now filters DOM elements by the .service-point__name class text to match the provided servicePointName, ensuring more precise selection of the intended service point button. [1] [2] [3] [4] [5]

Code cleanup:

  • Removed unnecessary import * as Cypress from 'cypress'; statements from all affected product repository files, as they were not needed for the current implementation. [1] [2] [3] [4] [5]

Steps before you submit a PR

  • Please add tests for the code you add if it's possible.
  • Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
  • Add a contribution-license-agreement.txt file with the following content:
    I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/cypress-tests/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.

This is a mandatory step to make sure you are aware of the license agreement and agree to it. HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@abitskil abitskil merged commit b9fb0f2 into master Nov 10, 2025
1 check passed
@abitskil abitskil deleted the bugfix/cc-36553-service-point-cart-cypress branch November 10, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants