Skip to content

Parse commented lines like an empty lines #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 50 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
33757f3
gh-277: parse commented line like an empty line
polo7 Jun 8, 2024
e4bb00a
Upgrade spring-boot 3.3.1
jvalkeal Jun 20, 2024
39bb2cd
Upgrade jline 3.26.2
jvalkeal Jun 20, 2024
a54eb09
Next development version
github-actions[bot] Jun 25, 2024
3c7d0ad
Next minor development version
jvalkeal Jun 25, 2024
16085e3
Upgrade spring-boot 3.4.0-M1
jvalkeal Jul 20, 2024
417789b
Upgrade jline 3.26.3
jvalkeal Jul 24, 2024
02011c8
Screen writer support for AttributedString
jvalkeal Jul 28, 2024
9021238
Overhaul StatusBar for better text use
jvalkeal Aug 9, 2024
2786b01
StringInput better unicode handling
jvalkeal Aug 13, 2024
b099398
Update docs for getting started
jvalkeal Aug 14, 2024
7165e2d
Fix inconsistent unknown option parsing
jvalkeal Aug 19, 2024
e76805b
Remove macos 11, add 13 and 14
jvalkeal Aug 20, 2024
9656623
Update e2e scheduling
jvalkeal Aug 20, 2024
208e41b
Upgrade spring-boot 3.4.0-M2
jvalkeal Aug 23, 2024
6983ef5
Bundle Javadoc with Antora
jvalkeal Aug 29, 2024
e1ef18e
Remove disabled tasks from docs
jvalkeal Aug 29, 2024
bad7588
Initial ffm support
jvalkeal Aug 30, 2024
f5521b7
Fix ToolchainPlugin
jvalkeal Aug 30, 2024
8f0a736
Docs updates for ffm
jvalkeal Sep 14, 2024
63d91d7
Add native ci workflow
jvalkeal Sep 14, 2024
5cd1b45
Relax javadoc source version
jvalkeal Sep 15, 2024
29b3c6d
JUnit tag support
jvalkeal Sep 15, 2024
a1032b6
Upgrade gradle 8.10.1
jvalkeal Sep 15, 2024
e295d37
Upgrade spring-boot 3.4.0-M3
jvalkeal Sep 20, 2024
747c030
Use jdk22 in e2e tests
jvalkeal Sep 20, 2024
094ffeb
Use jdk 22/17 in release workflows
jvalkeal Sep 21, 2024
bec5185
Update to Boot 3.4.0
Dec 10, 2024
9d2d0c0
Fix server id in JFrog configuration
Dec 10, 2024
7f702d5
Fix e2e macos configuration
Dec 10, 2024
497a41d
Update JFrog CLI Usage
Dec 10, 2024
d044e16
Add JF_SERVER_ID variable
Dec 10, 2024
7ebec6e
Remove macos-13
Dec 10, 2024
82176a0
Remove setup-maven
Dec 10, 2024
f3d1401
Update Next Version 3.4.1-SNAPSHOT
Dec 12, 2024
6147a32
Update gradle wrapper to version 8.12.1
fmbenhassine Feb 4, 2025
4490cc0
Update spring boot version to 3.5.0-SNAPSHOT
fmbenhassine Feb 7, 2025
9bc8353
Replace Pivotal CLA with DCO
fmbenhassine Feb 28, 2025
df12a4b
Upgrade gradle version to 8.13
fmbenhassine Apr 17, 2025
8f4e1b7
Update test dependencies for the latest Spring Boot 3.5 snapshots
fmbenhassine Apr 22, 2025
ff84b99
Update index.adoc
benson-yeh Mar 29, 2025
d909f79
Update dependencies
fmbenhassine Apr 24, 2025
e3cb937
Update documentation
fmbenhassine Apr 25, 2025
9962396
Fix typo in issue label description
srinivasu619 Dec 11, 2022
2f00d73
chore: bump spring-shell-e2e dependencies
codespearhead Jun 25, 2024
1088ba4
gh-277: parse commented line like an empty line
polo7 Jun 8, 2024
59218e2
Merge remote-tracking branch 'origin/gh-277' into gh-277
polo7 Apr 25, 2025
64c75a7
gh-277: added unit tests
polo7 Apr 28, 2025
01850aa
gh-277: added unit tests
polo7 Apr 28, 2025
1b75454
Merge remote-tracking branch 'origin/gh-277' into gh-277
polo7 Apr 29, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dco.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
require:
members: false
2 changes: 1 addition & 1 deletion .github/labels-manage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
description: Something needs to get done
- name: type/technical-debt
color: D4C5F9
description: Techical Dept
description: Technical Dept
- name: type/question
color: D4C5F9
description: Is a question
Expand Down
34 changes: 34 additions & 0 deletions .github/workflows/ci-native.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: CI Native

on:
workflow_dispatch:

jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
include:
- nickname: linux jdk17
java: 17
os: ubuntu-latest
- nickname: macos jdk17
java: 17
os: macos-latest
- nickname: windows jdk17
java: 17
os: windows-latest
name: CI Build ${{ matrix.nickname }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: adopt
java-version: |
22
17
cache: gradle
- name: Build
run: ./gradlew build

19 changes: 11 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: adopt
java-version: ${{ matrix.java }}
java-version: |
22
17
cache: gradle
- name: Build
run: ./gradlew build
Expand All @@ -41,21 +43,22 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: adopt
java-version: 17
java-version: |
22
17
cache: gradle
- uses: jfrog/setup-jfrog-cli@v3
with:
version: 2.21.5
env:
JF_URL: 'https://repo.spring.io'
JF_ENV_SPRING: ${{ secrets.JF_ARTIFACTORY_SPRING }}
- name: Configure JFrog Cli
run: |
jf rt gradlec \
jf gradlec \
--use-wrapper \
--uses-plugin \
--deploy-ivy-desc=false \
--server-id-resolve repo.spring.io \
--server-id-deploy repo.spring.io \
--server-id-resolve=${{ vars.JF_SERVER_ID }} \
--server-id-deploy=${{ vars.JF_SERVER_ID }} \
--repo-resolve snapshot \
--repo-deploy snapshot
echo JFROG_CLI_BUILD_NAME=spring-shell-main >> $GITHUB_ENV
Expand All @@ -68,5 +71,5 @@ jobs:
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }}
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_SECRET_ACCESS_KEY }}
run: |
jf rt gradle build distZip artifactoryPublish
jf gradle build artifactoryPublish
jf rt build-publish
14 changes: 5 additions & 9 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
graal: latest
musl: false
- nickname: macos
os: macos-12
os: macos-latest
graal: latest
musl: false
- nickname: linux
Expand All @@ -34,7 +34,7 @@ jobs:
- uses: graalvm/setup-graalvm@v1
with:
version: ${{ matrix.graal }}
java-version: 21
java-version: 22
components: native-image
native-image-musl: ${{ matrix.musl }}
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -74,9 +74,9 @@ jobs:
nickname: win
# - os: windows-2019
# nickname: win
- os: macos-12
- os: macos-14
nickname: macos
- os: macos-11
- os: macos-15
nickname: macos
- os: ubuntu-22.04
nickname: linux
Expand All @@ -93,12 +93,8 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: adopt
java-version: 21
java-version: 22
cache: gradle
- name: Use Python 3.11
uses: actions/setup-python@v4
with:
python-version: '3.11'
- uses: actions/setup-node@v2
with:
node-version: '16'
Expand Down
24 changes: 10 additions & 14 deletions .github/workflows/release-ga.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,21 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: adopt
java-version: 17
- uses: jvalkeal/setup-maven@v1
with:
maven-version: 3.8.4
java-version: |
22
17
- uses: jfrog/setup-jfrog-cli@v3
with:
version: 2.21.5
env:
JF_URL: 'https://repo.spring.io'
JF_ENV_SPRING: ${{ secrets.JF_ARTIFACTORY_SPRING }}
- name: Configure JFrog Cli
run: |
jf rt gradlec \
jf gradlec \
--use-wrapper \
--uses-plugin \
--deploy-ivy-desc=false \
--server-id-resolve repo.spring.io \
--server-id-deploy repo.spring.io \
--server-id-resolve=${{ vars.JF_SERVER_ID }} \
--server-id-deploy=${{ vars.JF_SERVER_ID }} \
--repo-resolve release \
--repo-deploy libs-staging-local
echo JFROG_CLI_BUILD_NAME=spring-shell-main-release >> $GITHUB_ENV
Expand Down Expand Up @@ -59,7 +57,7 @@ jobs:
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }}
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_SECRET_ACCESS_KEY }}
run: |
jf rt gradle build distZip artifactoryPublish
jf gradle build artifactoryPublish
jf rt build-publish
- name: Push Release
env:
Expand All @@ -81,9 +79,8 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: jfrog/setup-jfrog-cli@v3
with:
version: 2.21.5
env:
JF_URL: 'https://repo.spring.io'
JF_ENV_SPRING: ${{ secrets.JF_ARTIFACTORY_SPRING }}
- name: Configure JFrog Cli
run: |
Expand Down Expand Up @@ -157,9 +154,8 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: jfrog/setup-jfrog-cli@v3
with:
version: 2.21.5
env:
JF_URL: 'https://repo.spring.io'
JF_ENV_SPRING: ${{ secrets.JF_ARTIFACTORY_SPRING }}
- name: Configure JFrog Cli
run: |
Expand Down
19 changes: 8 additions & 11 deletions .github/workflows/release-milestone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,21 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: adopt
java-version: 17
- uses: jvalkeal/setup-maven@v1
with:
maven-version: 3.8.4
java-version: |
22
17
- uses: jfrog/setup-jfrog-cli@v3
with:
version: 2.21.5
env:
JF_URL: 'https://repo.spring.io'
JF_ENV_SPRING: ${{ secrets.JF_ARTIFACTORY_SPRING }}
- name: Configure JFrog Cli
run: |
jf rt gradlec \
--use-wrapper \
--uses-plugin \
--deploy-ivy-desc=false \
--server-id-resolve repo.spring.io \
--server-id-deploy repo.spring.io \
--server-id-resolve=${{ vars.JF_SERVER_ID }} \
--server-id-deploy=${{ vars.JF_SERVER_ID }} \
--repo-resolve milestone \
--repo-deploy libs-staging-local
echo JFROG_CLI_BUILD_NAME=spring-shell-main-milestone >> $GITHUB_ENV
Expand Down Expand Up @@ -63,7 +61,7 @@ jobs:
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }}
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_SECRET_ACCESS_KEY }}
run: |
jf rt gradle build distZip artifactoryPublish
jf rt gradle build artifactoryPublish
jf rt build-publish
- name: Push Release
env:
Expand All @@ -85,9 +83,8 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: jfrog/setup-jfrog-cli@v3
with:
version: 2.21.5
env:
JF_URL: 'https://repo.spring.io'
JF_ENV_SPRING: ${{ secrets.JF_ARTIFACTORY_SPRING }}
- name: Configure JFrog Cli
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/schedule-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Schedule e2e
on:
workflow_dispatch:
schedule:
- cron: '0 0 * * 1,3,5'
- cron: '0 0 * * 1,4'

permissions:
actions: write
Expand All @@ -14,7 +14,7 @@ jobs:
if: github.repository_owner == 'spring-projects'
strategy:
matrix:
branch: [ main, 3.2.x, 3.1.x ]
branch: [ main, 3.3.x, 3.2.x ]
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down
8 changes: 6 additions & 2 deletions CONTRIBUTING.adoc
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
If you have not previously done so, please fill out and
submit the https://cla.pivotal.io/sign/spring[Contributor License Agreement].
### Sign-off commits according to the Developer Certificate of Origin

All commits must include a Signed-off-by trailer at the end of each commit message to indicate that the contributor agrees to the [Developer Certificate of Origin](https://developercertificate.org).

For additional details, please refer to the blog post [Hello DCO, Goodbye CLA: Simplifying Contributions to Spring](https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring).

1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
plugins {
id "base"
id 'org.springframework.shell.root'
}

description = 'Spring Shell'
Expand Down
9 changes: 4 additions & 5 deletions buildSrc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ dependencies {
implementation(platform("org.springframework.boot:spring-boot-dependencies:${springBootVersion}"))
implementation "org.springframework.boot:spring-boot-gradle-plugin:${springBootVersion}"
implementation("org.springframework:spring-core")
implementation 'org.asciidoctor:asciidoctor-gradle-jvm:3.3.2'
implementation 'org.jfrog.buildinfo:build-info-extractor-gradle:4.29.0'
implementation "org.graalvm.buildtools:native-gradle-plugin:${nativeBuildToolsVersion}"
}
Expand All @@ -49,13 +48,13 @@ gradlePlugin {
id = "org.springframework.shell.docs"
implementationClass = "org.springframework.shell.gradle.DocsPlugin"
}
distPlugin {
id = "org.springframework.shell.root"
implementationClass = "org.springframework.shell.gradle.RootPlugin"
}
samplePlugin {
id = "org.springframework.shell.sample"
implementationClass = "org.springframework.shell.gradle.SamplePlugin"
}
toolchainPlugin {
id = "org.springframework.shell.toolchain"
implementationClass = "org.springframework.shell.gradle.ToolchainPlugin"
}
}
}
Loading