Parse commented lines like an empty lines #1087
Conversation
|
Hello, @jvalkeal ! I didn't want to disturb you but it seems you are the only active official in this repo. Could you please guide me with my further steps? I guess I need your approval here. |
- New Screen.Writer has new text method taking AttributedString instead of just String - Fixes spring-projects#1110
- Can change item text - Can position items by priority(true left, false right) and primary(sort for draw attempt) - Fixes spring-projects#1112
- Add unicode handling in flow components in AbstractTextComponent which allows StringInput to process unicode given from jline. - This add basic non-english character support for input. - Fixes spring-projects#1115
- Add note for interactive mode - Fixes spring-projects#1108
- Fix an issue where unknown option is wrongly lexed as an argument if it's later than an known valid option. - Essentially if `arg1` is only valid option `--arg1 value1 --arg2 value2` would not complain about `arg2`. - Fixes spring-projects#1120
- Remove javadoc related tasks from root project - Add aggregated javadoc task to spring-shell-docs - Various antora version updates - Bundle javadoc via collector into antora build - Remove refs to distZip in workflows - Relates spring-projects#1132
- i.e. disabling jar will make local publish fail - Relates spring-projects#1132
- Starter for jline ffm terminal provider - Build changes for compiling with gradle toolchains defaulting to jdk22 - spring-shell-sample-ffm which compiles with jdk22 - ci workflow setups jdk 17/22 - Relates spring-projects#1131
- Change toolchain to get configured immediately instead after project evaluation which somehow caused i.e. vscode not detect correct project jdk in use. - Relates spring-projects#1131
- Relates spring-projects#1131
- Essentially this is a workflow acting as a placeholder for doing further native development as it's easier to have on in a main branch. - Should eventually grow into one user can run manually for ffm development if it's required to build something on a gh platform.
- To prepare jdk17+ code, don't fail if there's more recent javadoc format. - Relates spring-projects#1131
- Prepare build so that we can use JUnit tags and define shellIncludeTags/shellExcludeTags from command line to override settings. - Needed for some of a new planned tests which would not work without full build. - Relates spring-projects#1131
Update to Commons-IO 2.18.0
Spring Boot 3.5 updated JUnit Jupiter from v5.11 to v5.12. With this new version, the junit-platform-launcher dependency must be declared explicitly.
fix type Signed-off-by: benson-yeh <[email protected]>
|
Thank you for the PR! LGTM 👍 Can you please rebase it on the latest Thank you upfront. |
fmbenhassine
changed the title
- Bump node-pty from 0.11.0-beta19 to 1.0.0 - Bump xterm-headless from 4.18.0 to 5.5.0 - Rename xterm-headless to @xterm/headless as per https://www.npmjs.com/package/xterm-headless - Unpin Python 3.11 in e2e test by reverting commit spring-projects@8097f1e because it's no longer necessary as explained in spring-projects#909 (comment) - Fixes spring-projects#909 - Fixes spring-projects#921
@fmbenhassine I've rebased my branch on top of |
|
Thank you for the update! However I don't see the PR rebased on the latest |
fmbenhassine
added
the
status/need-feedback
|
@fmbenhassine I went through PR creation once again and it shows me PR is already opened with changes I've made. |
|
@fmbenhassine this is my another PR instead of this one: #1168 |
Fixes GH-277.
Idea: we parse a line and then evaluate despite it is commented. If there is a quote inside of comment then we get an exception "Missing a closing quote" (line 141 in spring-shell-core/src/main/java/org/springframework/shell/jline/ExtendedDefaultParser.java). To avoid this behavoir we should treat commented line like an empty. Then evaluate() from spring-shell-core/src/main/java/org/springframework/shell/Shell.java will take care of it with its "fail fast" on line 195.