Skip to content

refactor: Use Collection#isEmpty() instead of comparing size() #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Use Collection#isEmpty() instead of comparing size() #2305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/springframework/hateoas/client/Traverson.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ public Link asTemplatedLink() {

private Link traverseToLink(boolean expandFinalUrl) {

Assert.isTrue(rels.size() > 0, "At least one rel needs to be provided!");
Assert.isTrue(!rels.isEmpty(), "At least one rel needs to be provided!");

return Link.of(expandFinalUrl ? traverseToExpandedFinalUrl().getUri().toString() : traverseToFinalUrl().getUri(),
rels.get(rels.size() - 1).getRel());
Expand Down
2 changes: 1 addition & 1 deletion ...va/org/springframework/hateoas/mediatype/collectionjson/Jackson2CollectionJsonModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ public JsonSerializer<?> getContentSerializer() {
@Override
@SuppressWarnings("null")
public boolean isEmpty(PagedModel<?> value) {
return value.getContent().size() == 0;
return value.getContent().isEmpty();
}

/*
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/springframework/hateoas/server/core/WebHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ private static <T extends LinkBuilder> PreparedWebHandler<T> linkTo(Object invoc
if (mappingVariable.isCapturing()) {

List<String> segments = Arrays.asList(((String) preparedValue).split("/"));
Object value = segments.size() != 0 ? "/" + segment.composite().prepareAndEncode(segments) : "";
Object value = !segments.isEmpty() ? "/" + segment.composite().prepareAndEncode(segments) : "";

values.put(key, value);

Expand Down