Use Collection#isEmpty() instead of comparing size()
#2305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Oledzki <[email protected]>
greg-at-moderne
force-pushed
the
refactor/use-collection-is-empty-instead-of-comparing-size
branch
from
ed918e8 to
c67efe4
Compare
odrotbohm
pushed a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Greg Oledzki <[email protected]>
|
That's merged, thanks! |
odrotbohm
changed the title
Collection#isEmpty() instead of comparing size()Collection#isEmpty() instead of comparing size()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changing calls to
Collections.size() == 0toCollection.isEmpty().Why:
This is more readable and likely also more efficient.
How:
This has been generated using OpenRewrite's https://docs.openrewrite.org/recipes/staticanalysis/isemptycalloncollections