Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugifx: rolling back to the previous sentry and sentry-tracing versions #991

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Bugifx: rolling back to the previous sentry and sentry-tracing versions #991

merged 1 commit into from
Mar 1, 2024

Conversation

dcookspi
Copy link
Collaborator

Rolling back to the previous sentry and sentry-tracing version stops spk publish hanging when it errors due to an existing version.

@dcookspi
Bugifx: rolling back to the previous sentry and sentry-tracing versio…
72a364f 
…n stops spk publish hanging when it errors due to an existing version

Signed-off-by: David Gilligan-Cook <[email protected]>
@dcookspi dcookspi self-assigned this Feb 29, 2024
@dcookspi dcookspi linked an issue Feb 29, 2024 that may be closed by this pull request
[BUG] spk publish (debug build) hangs when erroring #990
Closed
@dcookspi dcookspi requested review from jrray and rydrman February 29, 2024 21:13
@dcookspi dcookspi mentioned this pull request Feb 29, 2024
Closed
jrray
jrray approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@jrray jrray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support rolling this back, I intend to try to investigate the problem further and perhaps submit an issue on the sentry repo.

rydrman
rydrman approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@rydrman rydrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using this so fine by me

@dcookspi dcookspi merged commit 5b3405f into main Mar 1, 2024
7 checks passed
@dcookspi dcookspi deleted the 990-bug-spk-publish-bebug-build-hangs-when-erroring branch March 1, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrray jrray jrray approved these changes

@rydrman rydrman rydrman approved these changes

Assignees

@dcookspi dcookspi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] spk publish (debug build) hangs when erroring
3 participants
@dcookspi @jrray @rydrman