-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] spk publish (debug build) hangs when erroring #990
Comments
We decided to go with rolling back to the earlier sentry version. |
Using git bisect on the sentry-rust repo I tracked the hanging down to this commit. Then, going back to the "good" version 0.27.0 but enabling the I'm about to start looking into what that feature does. BTW I found a simple way to reproduce the hang by simply doing |
Attaching a debugger to the hanging spk process shows something similar to what we saw in the past:
|
I found an issue that is effectively about our problem: getsentry/sentry-rust#358 |
Avoid enabling the default feature `debug-images` which was causing the deadlock on centos 7. `cargo tree -e features -i sentry` is useful for verifying the list of enabled features. More details can be found in issue #990. Signed-off-by: J Robert Ray <[email protected]>
This was 2 employers and 3 years ago but I do seem to remember the defect I reported to sentry was not present when we tested on a later Linux kernel. Nobody was thrilled with the idea of deviating from the kernel Centos 7 brought by default. I'm sorry to hear this is still something to worry about 😭 Nice job narrowing things to the debug-images feature 👏🏻 |
spk publish
from a debug builds hangs when erroring instead of outputting the error and exiting.To Reproduce
Steps to reproduce the behavior:
spk convert pip ...
using an existing package/version, but stopped it from publishing thebuild, e.g.spk convert pip -- --python-version 3.7 --python-abi cp37m colorama==0.4.6
and answer 'N' when asked.target/debug/spk publish -r origin python-colorama/0.4.6
Expected behavior
Additional context
The debug build does not hang if you downgrade the
sentry
andsentry-tracing
dependencies in the Cargo.toml from0.32.2
to the previous version spk used:0.27.0
Added a branch and PR with the sentry rollback that seems to fix it: #991
The text was updated successfully, but these errors were encountered: