Skip to content

Fix missing return value in getBemf() method of Haptic_Driver.cpp #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix missing return value in getBemf() method of Haptic_Driver.cpp #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Haptic_Driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,8 @@ float Haptic_Driver::getBemf()
case 0x03:
return 49.9;
}
Copy link

@tyirvine tyirvine Sep 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this pull request. Check the comment above the function. It states the default value is 0x01 or 4.9mV. In the switch statement you could insert the following:

default:
  return 4.9;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you on this.


return 0.0;
}

void Haptic_Driver::createHeader(uint8_t numSnippets, uint8_t numSequences)
Expand Down