Fix missing return value in getBemf() method of Haptic_Driver.cpp #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While trying the I2C_mode example using Arduino IDE 2.3.4, I encountered the following error during compilation:
It seems the issue is that the getBemf() method not having a default return value, even though it is declared to return a float. The error occurs even when I only import "Haptic_Driver.h" without using the library in my code, which suggests it is an issue with the library's implementation rather than usage.
Fix
I added a return 0.0 at the end of the method as a workaround, and the example compiled successfully.
Concerns
I am unsure whether returning 0.0 is appropriate, as I am not familiar with the intended behavior of the getBemf() method. If another value is more appropriate, I am open to suggestions.