Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intercom key deletion but for real this time #34911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix intercom key deletion but for real this time #34911

wants to merge 1 commit into from

Conversation

Booblesnoot42
Copy link
Contributor

About the PR

Fixes an issue where intercom keys would be deleted from intercoms when a secure plate is removed.

Why / Balance

Fixes #32590
Fixes #34054
(Duplicate Issues)

Technical details

Previously, the construction component for the intercom didn't have the containers set up. As a result, it would delete the keys instead of transferring them when the entity type changed.

Media

encryptionKeyFix.mp4

Requirements

Breaking changes

Changelog

🆑

  • fix: Removing the security plate from an intercom will no longer delete its encryption keys.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Feb 6, 2025
@Booblesnoot42 Booblesnoot42 mentioned this pull request Feb 6, 2025
Closed
2 tasks
slarticodefast
slarticodefast approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. Thanks for the bugfix!

@slarticodefast slarticodefast self-assigned this Feb 6, 2025
@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Feb 6, 2025
@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
3 participants
@Booblesnoot42 @slarticodefast @ArtisticRoomba