Fixed Intercom Encryption Key Deletion

[Booblesnoot42]

About the PR

Fixed an issue wherein using a welding tool on any intercom which inherited from BaseIntercomSecure, which should remove the security plate and allow access to the encryption keys, would delete all the encryption keys within it.

Why / Balance

Fixes #32590
Fixes #34054
(Duplicate Issues)

Technical details

Change:
Changes the construction system to check abstract parents when checking if an entity inherits from a construction node's desired prototype.

Explanation:
The problem is in how the "doNotReplaceInheritingEntities" code works. When an entity changes nodes on a construction graph, it is supposed to change to match the new node's prototype unless it is already that type. If "doNotReplaceInheritingEntities" is set to true, however, than it only needs to change if it doesn't inherit from the node's prototype rather than needing to match the type exactly. The function currently used to find the entity's parents doesn't check abstract parents or their grandparents, however, resulting in the error.

For example, the CommandIntercom inherits from BaseIntercomSecure (an abstract prototype) which itself inherits from IntercomConstructed. The BaseIntercomSecure prototype sets the construction node to "intercomReinforced." When a player uses the welding tool on the command intercom, it changes from the "intercomReinforced" node to the "intercom" node. The "intercom" node has its prototype set as "IntercomConstructed", and the doNotReplaceInheritingEntities field set to true; as a result, the intercom shouldn't change prototypes because the construction system should recognize that it inherits from IntercomConstructed through BaseIntercomSecure. Because BaseIntercomSecure is abstract, however, the system won't realize that the intercom inherits from IntercomConstructed and will change the CommandIntercom into an IntercomConstructed, deleting the keys in the process.

Media

intercom.encryption.fix.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None that I'm aware of.
Changelog

🆑

• fix: Removing the security plate from an intercom will no longer delete its encryption keys.

[cohanna]

#33267 seeks to achieve a similar thing (linked for visibility)

[Booblesnoot42]

Closed: found a better solution -> #34911