LogSystem/SharpSystem replaced by SliceableSystem/ButcherableSystem, etc.

[Plykiya]

About the PR

I wanted to work towards this issue #28141 when I realized how deep I had to go to fix this, so I haven't actually touched SliceableFoods yet.

• LogComponent and LogSystem in Content.Server replaced by more generic SliceableComponent and SliceableSystem in Content.Shared
• SharpComponent replaced by ToolComponent and the "Slicing" ToolQualityPrototype and all instances of it replaced as such
• SharpSystem in Content.Server replaced by ButcherableSystem in Content.Shared

LogComponent and LogSystem's entire purpose was just "if sharp object used, spawn these items". Sliceable does the same but in shared. I wanted to merge Sliceablefoods into it, but considering the current amount of changed files, I chose not to do that yet.

SharpComponent had a TODO saying to just make it a tool type. I deleted the SharpComponent and replaced every instance of it by adding the ToolComponent with the "Slicing" quality. When code checked for the presence of the SharpComponent, I checked for the ToolComponent and the "Slicing" ToolQualityPrototype instead.

SharpSystem, despite the name being quite generic, was used solely for the do-after and verbs related to butchering. I moved this all to the ButcherableSystem in Content.Shared instead, along with any changes required to make it not use the SharpComponent.

Why / Balance

LogComponent isn't generic enough, and SliceableFood should be merged into the new Sliceable stuff after this PR to address #28141
SharpComponent had a TODO comment saying it didn't need to be a component, could just be a tool quality. So I did that.

Technical details

• SharpComponent deleted, replaced by ToolComponent with the "Slicing" ToolQualityPrototype. This is most of the yml changes.
• Any checks for SharpComponent replaced by a check for ToolComponent and using the SharedToolSystem to check if the ToolComponent has the "Slicing" ToolQualityPrototype.
• SharpSystem in Content.Server replaced by ButcherableSystem in Content.Shared. This makes the butcher verb predicted. Spawning and deletion of entities are only run on the server.
• SharpSystem AfterInteractEvent subscription changed to ButcherableSystem InteractUsingEvent subscription. Previously, the knife checked if it interacted on a butcherable target. Now, the butcherable target checks if it was interacted with by a slicing tool.
• LogComponent and LogSystem in Content.Server replaced by SliceableComponent and SliceableSystem in Content.Shared. Spawning and deletion of entities are only run on the server.
• All do-afters args are gone and handled by UseTool() from the SharedToolSystem.
• Integration test for Slicing system checks that using a cleaver on a sliceable object spawns the desired products and that you can't slice non-sliceable objects.
• Integration test for Butcherable system checks that using a cleaver on a dead Ian spawns the desired products and that you can't butcher Ian while he's still alive.

Media

ButcherableSystem function + verb prediction and ToolQuality description:

2025-02-03.00-48-08.mp4

SliceableSystem function + Botany planter function:

2025-02-03.00-51-20.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

LogComponent and LogSystem have been removed and replaced by SliceableComponent and SliceableSystem.
SharpComponent has been removed and replaced by the usage of ToolComponent with a "Slicing" quality.
SharpSystem has been removed and replaced by the ButcherableSystem.

Changelog

🆑

• tweak: There is now a do-after and sound effect when splitting log types and cotton boll types.
• tweak: The butchering verb is now predicted, making it more responsive.
• tweak: The cargo knife bounty now requires knives and shivs specifically, rather than anything sharp such as swords. That means plastic knives can now be used for the bounty.
• tweak: The cargo knife bounty now asks for 18 knives instead of 5 knives.

[Plykiya]

I'll deal with the Sliceable arbitrage test fail and write tests for the Sliceable and Butcherable systems

[Plykiya]

so the new test fail is complaining that the large pizza box order comes with 15 pizzas, each with their own plastic knife, which can count towards the new knife bounty since it's only checking for a knife tag

what do I do about that

make the knife bounty way cheaper?

[Plykiya]

I just increased the amount of knives until the test stopped complaining. Good to review at this point.

[MilonPL]

Mostly good, minor style nitpicks. Keep in mind that EntitySystems in Shared also need their Client/Server parts, even if they don't have a body yet. So you should rename the ButherableSystem to SharedButcherableSystem, and then make a dummy EntitySystem in both Client and Server that will extend it. Same for SliceableSystem.

[MilonPL]

Remove the System part from all these, it shouldn't be used for dependencies. Sort it alphabetically.

[Plykiya]

Can this style convention be added to the conventions doc page?

https://docs.spacestation14.com/en/general-development/codebase-info/conventions.html

[MilonPL]

At some point in the near future yes, many parts of the the conventions are pending rewrite.

[Plykiya]

Mostly good, minor style nitpicks. Keep in mind that EntitySystems in Shared also need their Client/Server parts, even if they don't have a body yet. So you should rename the ButherableSystem to SharedButcherableSystem, and then make a dummy EntitySystem in both Client and Server that will extend it. Same for SliceableSystem.

They only need the Client/Server parts if the Shared system is abstract, requiring the dummy implementation on both Client and System.

Similarly, they don't need the Shared prefix since they only exist in Shared.

Good catches on some of the other reviews, thanks for them.

[MilonPL]

Yup, I was told that all EntitySystems in Shared should be abstract a long time ago and didn't really question it, but after checking with other maintainers, you're right on those.