Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix butcher verb making your right click UI bounce #34899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix butcher verb making your right click UI bounce #34899

wants to merge 1 commit into from

Conversation

DrSmugleaf
Copy link
Member

@DrSmugleaf DrSmugleaf commented Feb 5, 2025 •
edited
Loading

About the PR

Another day another thing that's not in shared 10000 dead shared soldiers this is epic
Also sensor verb is ALSO NOT PREDICTED BECAUSE ITS PROBABLY NOT IN SHARED BUT IM NOT FIXING THAT IN THIS PR WOO

Why / Balance

Technical details

Media

Requirements

Breaking changes

SharpComponent and SharpSystem moved from server to shared, alt+enter to fix imports on Rider.

Changelog
🆑

  • fix: Fixed butcher verb making your right click UI bounce.

@DrSmugleaf DrSmugleaf requested a review from Partmedia as a code owner February 5, 2025 10:02
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. S: Needs Review Status: Requires additional reviews before being fully accepted labels Feb 5, 2025
@slarticodefast
Copy link
Member

slarticodefast commented Feb 5, 2025 •
edited
Loading

I would prefer to merge #34851 instead which does the same but also gets rid of some unneeded systems.

@ArtisticRoomba ArtisticRoomba added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Refactor Type: Refactor of notable amount of codebase D3: Low Difficulty: Some codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Partmedia Partmedia Awaiting requested review from Partmedia Partmedia is a code owner

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Refactor Type: Refactor of notable amount of codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrSmugleaf @slarticodefast @ArtisticRoomba