Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bsp::uart as bsp::apb_uart #61

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Rename bsp::uart as bsp::apb_uart #61

merged 2 commits into from
Aug 20, 2024

Conversation

hegza
Copy link
Contributor

@hegza hegza commented Aug 20, 2024

... to disambiguate from sysctrl::uart. Make it clear to any user that apb_uart0 and apb_uart1 are the top-level, shared UARTs.

@hegza hegza requested a review from vilukissa68 August 20, 2024 11:51
@hegza
Copy link
Contributor Author

hegza commented Aug 20, 2024

@vilukissa68 Can you think of anything that might break as a result of this? Feel free to merge if you think this is non-breaking.

Copy link
Collaborator

@vilukissa68 vilukissa68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't think of anything that would break with these changes. The C-examples mostly rely on Newlib for UART functionality, which this doesn't affect. If something broke on the rust side dla-validation would have failed.

@vilukissa68 vilukissa68 merged commit b6b41f0 into main Aug 20, 2024
6 checks passed
@vilukissa68 vilukissa68 deleted the chore/rename-uart branch August 20, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants