Adds signed integers to DLA #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vilukissa68
commented
May 14, 2024
vilukissa68
commented
- Adds support for 8-bit signed integers to driver and VP
- Removes support for unsigned integers (u8) since those turned out not to be supported by the hardware
- Fixes signed clipping bounds
- Fixes PP clipping being dependant on ReLU
vilukissa68
changed the title
hegza
requested changes
May 14, 2024
examples/hpc/dla-driver/src/lib.rs
Outdated
| //sprintln!("\nWrite to bank {:#x}, data: {:?}", offset, buf); | ||
| for (i, b) in buf.iter().enumerate() { | ||
| unsafe { ptr::write_volatile((MEMORY_BANK_BASE_ADDR + offset + i) as *mut u8, *b) }; | ||
| unsafe { ptr::write_volatile((MEMORY_BANK_BASE_ADDR + offset + i) as *mut i8, *b) }; |
There was a problem hiding this comment.
You might want to elide the type in these assignments, if types are obvious from context, e.g. write_volatile(ADDR as *mut _, value). Say, you have a function like write_u8(), there is no need to re-specify the type in the implementation. This might come down to preference at the end of the day.
There was a problem hiding this comment.
Removed explicit type assignments.
Comment on lines
119
to
120
| let output: Vec<i8> = dla.read_output(output_width as usize * output_height as usize); | ||
| output |
There was a problem hiding this comment.
Style: return expression dla.read_output(output_width as usize * output_height as usize) without the extra assignment.
hegza
approved these changes
May 16, 2024
* Adds support for 8-bit signed integers to driver and VP * Removes support for unsigned integers (u8) since those turned out not to be supported by the hardware * Fixes signed clipping bounds * Fixes PP clipping being dependant on ReLU
vilukissa68
force-pushed
the
feat/signed-integers
branch
from
0577693 to
07c802b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.