Skip to content

Conversation

@hombit
Copy link
Member

@hombit hombit commented May 13, 2024

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codspeed-hq
Copy link

codspeed-hq bot commented May 13, 2024

CodSpeed Performance Report

Merging #182 will improve performances by ×18

Comparing devnet-notebook (6e740b5) with master (c78dece)

🎉 Hooray! pytest-codspeed just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 44 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_benchmark_fit_known 266.8 ms 205.8 ms +29.63%
test_benchmark_loss_gradient[1024-1024] 4.4 ms 3.9 ms +13.83%
test_benchmark_loss_gradient[1024-65536] 4.4 ms 3.9 ms +13.81%
test_benchmark_feature_signature[128] 555.7 µs 407.9 µs +36.24%
test_benchmark_feature_signature[2] 563.4 µs 411.9 µs +36.77%
test_benchmark_fit_sklearn[1024] 5.3 s 4.5 s +17.49%
test_benchmark_fit_sklearn[128] 668.1 ms 568.9 ms +17.42%
test_benchmark_score[1024] 8.5 ms 7 ms +22.18%
test_benchmark_score[1048576] 8.4 s 6.9 s +21.17%
test_benchmark_score_samples[1-128-1024] 9.8 ms 8.3 ms +18.56%
test_benchmark_score_samples[1-128-1048576] 9.7 s 8.3 s +17.57%
test_benchmark_score_samples[1-128-1] 264.8 µs 127.1 µs ×2.1
test_benchmark_score_samples[1-128-32] 614.1 µs 456.7 µs +34.47%
test_benchmark_score_samples[1-256-1024] 18 ms 15.1 ms +19.5%
test_benchmark_score_samples[1-256-1048576] 17.9 s 15 s +19.17%
test_benchmark_score_samples[1-256-1] 276.2 µs 160.7 µs +71.83%
test_benchmark_score_samples[1-256-32] 978.7 µs 773.4 µs +26.54%
test_benchmark_score_samples[1-64-1024] 5.6 ms 4.8 ms +17.47%
test_benchmark_score_samples[1-64-1048576] 5.5 s 4.7 s +15.41%
test_benchmark_score_samples[1-64-1] 223.6 µs 111.5 µs ×2
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@matwey
Copy link
Contributor

matwey commented Jul 3, 2025

@hombit devnet.ipynb cannot be open due to corrupted format, can you handle it?

@hombit hombit force-pushed the devnet-notebook branch from 1be6300 to 0821ef3 Compare July 3, 2025 15:36
@matwey
Copy link
Contributor

matwey commented Jul 3, 2025

What is going on here? Why this is rebased on top of rust?

@hombit
Copy link
Member Author

hombit commented Jul 3, 2025

@matwey because I want to run it faster on mac

@matwey matwey changed the base branch from master to rust July 3, 2025 19:08
@matwey
Copy link
Contributor

matwey commented Jul 4, 2025

@hombit devnet.ipynb is still broken. I don't know how did you run it:

Unreadable Notebook: /home/matwey/lab/coniferest/docs/notebooks/devnet.ipynb NotJSONError('Notebook does not appear to be JSON: \'{\\n "cells": [\\n {\\n "cell_type": "c...')

Base automatically changed from rust to master July 4, 2025 12:59
@hombit hombit force-pushed the devnet-notebook branch from 2bcb5f4 to 34663e2 Compare July 10, 2025 20:16
@hombit hombit force-pushed the devnet-notebook branch from 9900bdb to 6e740b5 Compare July 11, 2025 15:28
@matwey
Copy link
Contributor

matwey commented Jul 30, 2025

Can we please rebase this on master? I guess we need this notebook to be merged for the Pineforest paper release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants