Skip to content

Disable Vault.secrets.get method from gateway #21332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashantkumar1982 merged 1 commit into from
Feb 27, 2026
Merged

Disable Vault.secrets.get method from gateway #21332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions core/services/gateway/handlers/vault/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,15 +357,6 @@ func (h *handler) HandleJSONRPCUserMessage(ctx context.Context, req jsonrpc.Requ
}
h.lggr.Debugw("returning cached public key response")
return h.handlePublicKeyGetSynchronously(ctx, req, publicKeyResponseBytes, callback)

case vaulttypes.MethodSecretsGet:
// Secrets get is only allowed in non-production builds for testing purposes
// So no authorization is required
ar, err := h.newActiveRequest(req, callback)
if err != nil {
return err
}
return h.handleSecretsGet(ctx, ar)
}

isAuthorized, owner, err := h.requestAuthorizer.AuthorizeRequest(ctx, req)
Expand Down
3 changes: 2 additions & 1 deletion system-tests/tests/smoke/cre/v2_vault_don_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ func ExecuteVaultTest(t *testing.T, testEnv *ttypes.TestEnvironment) {
framework.L.Info().Msg("Waiting 30 seconds for the Vault DON to be ready...")
time.Sleep(30 * time.Second)
executeVaultSecretsCreateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
// Disable Vault Get tests
// executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
Copy link
Contributor

@cedric-cordenier cedric-cordenier Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a follow up to refactor this test so it executes a workflow? That way we'll at least maintain our test coverage

Copy link
Contributor Author

@prashantkumar1982 prashantkumar1982 Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

executeVaultSecretsUpdateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
executeVaultSecretsListTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
executeVaultSecretsDeleteTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
Expand Down
Loading