Disable Vault.secrets.get method from gateway#21332
Merged
prashantkumar1982 merged 1 commit intorelease/2.35.1from Feb 27, 2026
Merged
Disable Vault.secrets.get method from gateway#21332prashantkumar1982 merged 1 commit intorelease/2.35.1from
prashantkumar1982 merged 1 commit intorelease/2.35.1from
Conversation
Contributor
|
I see you updated files related to
|
|
cedric-cordenier
approved these changes
Feb 27, 2026
| executeVaultSecretsCreateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) | ||
| executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) | ||
| // Disable Vault Get tests | ||
| // executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) |
Contributor
There was a problem hiding this comment.
Should we add a follow up to refactor this test so it executes a workflow? That way we'll at least maintain our test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same PR was added to previous release too: #21323