Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment key error #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheRusskiy
Copy link

@TheRusskiy TheRusskiy commented Oct 10, 2020

@zvkemp
Copy link
Contributor

zvkemp commented Oct 12, 2020

Thanks for the PR @TheRusskiy! It looks like you are correct, at least in one sense. Part of the confusion comes from a general overloading of the environment term; in Skylight.start! it is used to select the environment-specific values from your yaml config, but does not specify the environment on Skylight.io into which data is reported. We are going to re-consider how these terms are used and hopefully will come up with a clearer way to differentiate these concepts. I'm going to leave this PR open in the meantime, we will re-address it when we've made some decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants