Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment docs error #156

Closed
TheRusskiy opened this issue Oct 10, 2020 · 1 comment
Closed

Environment docs error #156

TheRusskiy opened this issue Oct 10, 2020 · 1 comment

Comments

@TheRusskiy
Copy link

Is there an error in the docs? They say to use the env key, while in the code it's environment

skylight-ruby/lib/skylight/config.rb

Line 280 in 9072ec3

environment = opts.delete(:environment)

https://www.skylight.io/support/environments#2-require-and-start-the-skylight-agent-in-each-of-your-desired-environments
Screenshot from 2020-10-10 21-03-03
@TheRusskiy
Copy link
Author

Just noticed the docs are open source :-)
Here's a PR to fix them: skylightio/skylight-docs#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheRusskiy