[FEATURE] generate placeholder images internal #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ulrichmathes
force-pushed
the
166-placeholdercom-is-down-from-time-to-time
branch
2 times, most recently
from
0740314 to
dbdd15f
Compare
ulrichmathes
force-pushed
the
166-placeholdercom-is-down-from-time-to-time
branch
from
dbdd15f to
2bee084
Compare
s2b
approved these changes
Oct 24, 2024
ulrichmathes
force-pushed
the
166-placeholdercom-is-down-from-time-to-time
branch
2 times, most recently
from
cc08c05 to
ee9dd32
Compare
ulrichmathes
force-pushed
the
166-placeholdercom-is-down-from-time-to-time
branch
from
ee9dd32 to
2b84f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used #119 as a starting point and added a SVG which is used inline as image
src. The placeholder images now uses svg as standard as it does not uses disk space for generated pixel images.Thanks sascha-egerer for the GifBuilder part and Ralf for the SVG file.