MNT Update unit test to work with framework 4.9 #1097
Conversation
| // no space addresses is for framework 4.9 which does trim() email addresses | ||
| $to = '[email protected]; [email protected]'; | ||
| $from = '[email protected]; [email protected]'; | ||
| $found = (bool)static::findEmail($to, $from, 'Test Email'); |
There was a problem hiding this comment.
why not adjust findEmail() rather than adding this condition
There was a problem hiding this comment.
Good idea, I'll do that and close this PR
|
Closed in favour of updating findEmail() in silverstripe/silverstripe-framework#10065 |
|
Turns out we still need this even after merging the framework PR as userforms is still failing https://app.travis-ci.com/github/silverstripe/silverstripe-userforms/jobs/534130373 |
emteknetnz
force-pushed
the
pulls/5.9/fix-unit-test
branch
from
e4fc912 to
221a3ea
Compare
There was a problem hiding this comment.
I think the problem is that the other PR only sanitises the "To" field. The From field should be sanitise as well. The current test passes when I run it against this PR: silverstripe/silverstripe-framework#10089
|
Nope this PR is still needed after retriggering build after the other PR was merged. Also that other fix won't fix it for framework 4.8 or lower |
Issue silverstripe/recipe-cms#47
Requires this to be merged first silverstripe/silverstripe-framework#10065