Add silverstripe/session-manager

[brynwhyman]

On enhancing the session-manager module, it's something that's likely to provide broad benefit and is almost a baseline feature for any CMS or tool where software users manage their profile.

When considering the path of least resistance on making this module available to projects, this recipe was considered the best place to add it.

Other options that were considered were, from widest distribution to least distribution:
a) require as part of silverstripe/admin (aka "add it to core")
b) require as part of silverstripe/recipe-cms (not recipe-core, that does not include admin)
c) require as part of silverstripe/installer
d) require as part of silverstripe/silverstripe-security-extensions (not even sure what uses this?)
e) manually add to project (this is always an option)

Questions of stability

The silverstripe/session-manager module has been out in the wild for some time with a 0.x tag while early testing and feedback is sought.

We've been managing a bit of testing and user feedback internally, which will help us confirm confidence in tagging the module as stable and including it in this recipe.

Implementation tasks

Tasks required as part of this issue could be:

• Tag the module as stable
• Add the module to recipe-cms
• Tag session-manager version 1.1.0 when all PR's merged and create 1.1 branch
• After PR adding module to recipe-cms has been merged, ensure that session-manager pre-stable is removed from project skeleton
• Ensure the next changelog reflects this change
• Move userhelp docs into core (and out of the 'optional modules' section). See: Add session-manager docs to core silverstripe-session-manager#85

PRs - update unit tests to use logInAs()

• MNT Update tests to use logInAs() silverstripe-admin#1245
• FIX Update unit test to use TestSession for session silverstripe-asset-admin#1230
• MNT Update tests to use logInAs() silverstripe-cms#2679
• MNT Update tests to use logInAs() silverstripe-framework#10052
• MNT Update tests to use logInAs() silverstripe-versioned#340

PRs - follow up

• MNT Use logInAs() for unit tests silverstripe-cms#2682
• MNT Skip tests when session-manager module is installed silverstripe-framework#10073
• MNT Update unit tests to use logInAs() silverstripe-framework#10066
• DOC Add information regarding Security::setCurrentUser() silverstripe-framework#10061

PR - update recipe-cms

• DEP Add session manager #48 (merge after PRs above)

PRs - Docs

• DOC Add session-manager to changelog silverstripe-framework#10042
• DOC Move userhelp to silverstripe-userhelp-content silverstripe-session-manager#86
• DOC Add session-manager userhelp silverstripe-userhelp-content#164

PRs - Sink (remember to merge-up)

• MNT Fix unit tests to work with session-manager module silverstripe-gridfieldqueuedexport#50

SwiftMailer v6 not allowing spaces at start or end of email addresses

• (not session-manager though still breaking sink)
• FIX Trim email addresses to comply with RFC 2822, 3.6.2 silverstripe-framework#10065

TODO

• Probably skip some framework tests related to RememberLoginHash if session-manager is present and rely on the session-manager unit tests instead - see comment below

[emteknetnz]

https://travis-ci.com/github/silverstripe/silverstripe-installer/jobs/532576643
https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/jobs/532563593

• Fixed some tests with PRs
• A bunch of the "RememberLoginHash" ones behave differently because of this https://github.com/silverstripe/silverstripe-session-manager/blob/1/src/Middleware/LoginSessionMiddleware.php#L39 which will interfere with things like this https://github.com/silverstripe/silverstripe-framework/blob/4/tests/php/Security/MemberTest.php#L1206
• We may need to just skip these tests if Session Manager is present and rely on the unit testing within Session Manager instead to ensure that the correct number of devices are logged in correctly

https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/jobs/532563590

• Fixed with PR to gridfield extensions

https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/jobs/532563602

• Swiftmailer, not session-manager