BUG Update installer to create the assets folder if its missing

[maxime-rainville]

If you start your project with composer create-project silverstripe/recipe-cms, the assets folder doesn't get created automatically. The installer falls on its face if the assets folder doesn't exists.

This PR simply makes that directory if it's missing and writeable.

Parent issue

• Using Recipe-CMS as project base fails (install.php needs missing assets folder) recipe-cms#25

[kinglozzer]

Should this be wrapped in an if ($this->checkModuleExists('assets')) {? I realise there’s existing assets-related code in the installer that isn’t, just thought I’d raise it as a suggestion 😅

[ScopeyNZ]

Is ASSETS_PATH even defined in framework? I would've thought it would be part of silverstripe-assets.

[dhensby]

Yes: https://github.com/silverstripe/silverstripe-framework/blob/4/src/includes/constants.php

[maxime-rainville]

assets is defined as a dependency of framework.

silverstripe-framework/composer.json

Line 36 in b77771e

"silverstripe/assets": "^1@dev",

I think it's safe to assume it will always be there.

[maxime-rainville]

Just had a quick look to see if it would possible to decouple framework from assets. There's references to assets pretty much everywhere, even in things that you wouldn't think have anything to do with managing files.

[michalkleiner]

So... is extracting assets into its own module a good thing? Should it be again a part of the framework?

[maxime-rainville]

In the long run, I think there's some value, if only to provide a way to precisely target which version of assets you want to use.

We probably should avoid adding more inter-dependencies ... although I don't think this PR is the straw that will break this camel's back.

[chillu]

🐪