Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Recipe-CMS as project base fails (install.php needs missing assets folder) #25

Closed
albanyacademy opened this issue Mar 28, 2019 · 1 comment

Comments

@albanyacademy
Copy link

Trying to create project via composer using this repo as a base (as suggested in the readme) fails to fully install necessary files.

composer create-project silverstripe/recipe-cms --prefer-dist .

Go to localhost/websitename (in this case project folder was callled contracts)

( ! ) Fatal error: Uncaught UnexpectedValueException: RecursiveDirectoryIterator::__construct(C:\wamp64\www\contracts\public\assets,C:\wamp64\www\contracts\public\assets): The system cannot find the file specified. (code: 2) in C:\wamp64\www\contracts\vendor\silverstripe\framework\src\Dev\Install\InstallRequirements.php on line 288
--

1 | 0.0022 | 407152 | {main}( ) | ...\install.php:0
2 | 0.0057 | 408040 | include( 'C:\wamp64\www\contracts\vendor\silverstripe\framework\src\Dev\Install\install.php' ) | ...\install.php:15
3 | 0.0083 | 409080 | include( 'C:\wamp64\www\contracts\vendor\silverstripe\framework\src\Dev\Install\install5.php' ) | ...\install.php:25
4 | 0.2722 | 682280 | SilverStripe\Dev\Install\InstallRequirements->check( ) | ...\install5.php:69
5 | 0.2841 | 691544 | __construct ( ) | ...\InstallRequirements.php:288

Either the assets folder needs to be included as in the installer repo, or the readme should be updated to indicate this can't be used as a project base.

Workaround
just copying and pasting in the assets folder and its files from the installer repo mitigates this issue.

@maxime-rainville
Copy link
Contributor

I confirmed the issue. dev/build normally creates that folder if it's missing. However, the installer doesn't appear to do it.

Could have a look to see if we can get the recipe to create the assets folder on composer install. Otherwise, we can try to get the installer.php to assets if it's missing.

Made a PR for it silverstripe/silverstripe-framework#8890

@chillu chillu closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants