MNT Skip tests when session-manager module is installed #10073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2021
maxime-rainville
requested changes
Aug 24, 2021
|
@maxime-rainville these tests are non-nonsensical IMO when session-manager is installed, because of this line in the session-manager middleware
The tests are explicitly modifying |
maxime-rainville
approved these changes
Sep 2, 2021
maxime-rainville
force-pushed
the
pulls/4/skip-login-hash-tests
branch
from
c8101e6 to
3be8b3a
Compare
|
I fixed the comma and updated the build to run recipe-cms 4.9.x just to keep this moving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/recipe-cms#47