Skip to content

Fix the build for Rust 1.38, protobuf releases #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2019
Merged

Fix the build for Rust 1.38, protobuf releases #550

merged 4 commits into from
Sep 30, 2019

Conversation

michaelsproul
Copy link
Member

Lighthouse doesn't build with protobuf 2.9.0, and there's no point upgrading when it's about to be deleted.

@michaelsproul
Pin protobuf version to 2.8.x
23bcf9f 
Lighthouse doesn't build with protobuf 2.9.0, and there's no point
upgrading when it's about to be deleted.
@michaelsproul michaelsproul changed the title Pin protobuf version to 2.8.x Pin protobuf version to 2.8.x and run rustfmt Sep 30, 2019
@michaelsproul
Copy link
Member Author

Hmm rustfmt has updated in a backwards incompatible way too, and seems to have regressed on how it formats our log macro lines. I'll look into it (updated to use the crappy formatting for now)

@michaelsproul
Copy link
Member Author

Formatting regression seems to be related to rust-lang/rustfmt#3774

I guess we sit it out and wait for a new Rust release + rustfmt version

@paulhauner paulhauner mentioned this pull request Sep 30, 2019
Closed
@paulhauner paulhauner added the ready-for-review The code is ready for review label Sep 30, 2019
@michaelsproul michaelsproul changed the title Pin protobuf version to 2.8.x and run rustfmt Fix the build for Rust 1.38, protobuf releases Sep 30, 2019
@michaelsproul
Copy link
Member Author

Today is not our day!

The new Rust 1.38 release broke the parsing of the #[signed_root(skip_hashing)] attribute, which I'd attempted to fix in #544 😓. With that fixed, I think the build should pass now 🤞

@michaelsproul michaelsproul mentioned this pull request Sep 30, 2019
Closed
@paulhauner paulhauner merged commit 682b11f into master Sep 30, 2019
@michaelsproul michaelsproul deleted the protobuf-2.8 branch September 30, 2019 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @paulhauner