Skip to content

Require Beta and/or Nightly to pass CI #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelsproul opened this issue Sep 30, 2019 · 1 comment
Closed

Require Beta and/or Nightly to pass CI #553

michaelsproul opened this issue Sep 30, 2019 · 1 comment
Labels
test improvement Improve tests

Comments

@michaelsproul
Copy link
Member

Description

We allow compilation to fail on the Beta and Nightly channels, which leaves us blind to upcoming breaking changes in the Rust compiler (as happened today with #550). I think we should require compilation to succeed, but not cargo fmt, as writing multi-version code is reasonable, but requiring different versions of rustfmt to agree is not.

Steps to resolve

Remove beta and nightly from the allowed failures field of the Travis config, and modify the build script so that it only runs cargo fmt on stable. It looks like we should be able to use the TRAVIS_RUST_VERSION environment variable.
@michaelsproul michaelsproul added the test improvement Improve tests label Sep 30, 2019
@michaelsproul
Copy link
Member Author

We do this implicitly now, as part of running cargo +nightly udeps, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test improvement Improve tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelsproul