WIP: IconByName Refactor POC #108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please let me handle this issue |
|
@Shubhambawner Go for it! |
…endant mode, ref.: https://github.com/lerna/lerna#independent-mode , the problem: common-lib uses older version of prettier, but as main package enfoeces its version, the actual version being in action is newer one, so the deprecation warnings show up
lerna configuration: independent mode, now all packages can use independent mode, ref.: https://github.com/lerna/lerna#independent-mode , the problem: common-lib uses older version of prettier, but as main package enforces its version, the actual version being in action is newer one, so the deprecation warnings show up
prettified IconByNameCopy.js to avoid build error by prettier
Update lerna.json: independent mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to figure out a DRY way to make this happen.
Changes
IconByNameCopyis a POC that is planned to replaceIconByName. Right now it doesn't work.How to test
yarn start