Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettified IconByNameCopy.js to avoid build error by prettier #119

Merged
merged 7 commits into from
Jun 27, 2022
Merged

prettified IconByNameCopy.js to avoid build error by prettier #119

merged 7 commits into from
Jun 27, 2022

Conversation

Shubhambawner
Copy link
Contributor

@Shubhambawner Shubhambawner commented Jun 10, 2022 •
edited
Loading

Description

Petrified IconByNameCopy to avoid corresponding build error.

Changes

  1. ran prettier re-formatting for IconByNameCopy.js

reference to: PR #108

@Shubhambawner
a1: ran prettier formatting
c813f85
@Shubhambawner
lerna configuration: independant mode, now all packages can use indep…
9719b42 
…endant mode, ref.: https://github.com/lerna/lerna#independent-mode , the problem: common-lib uses older version of prettier, but as main package enfoeces its version, the actual version being in action is newer one, so the deprecation warnings show up
ChakshuGautam
ChakshuGautam reviewed Jun 10, 2022
View reviewed changes
Copy link
Contributor

@ChakshuGautam ChakshuGautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the files that are not part of the change. Here IconByNameCopy and yarn-error.log are not relevant.

@Shubhambawner
Copy link
Contributor Author

can I add yarn-error.log to gitIgnore ?

@Shubhambawner
Copy link
Contributor Author

Shubhambawner commented Jun 10, 2022 •
edited
Loading

also, IconByNameCopy has been prettified, I missed to mention, the file was not initially compliant with prettier, resulting to an error.

@Shubhambawner
Copy link
Contributor Author

Also, this is a temporary fix,
the permenant would be, acc. to me:
running (automatically or manually ? ) prettier write . instead of prettier check . before commiting/making pr, as this would either a way enforce prefered code formatting standard.

@Shubhambawner Shubhambawner changed the title Fix lerna configuration for independent mode (each package to have independent dependency versions ) prettified IconByNameCopy.js to avoid build error by prettier Jun 13, 2022
@ChakshuGautam ChakshuGautam merged commit 26cafc1 into shiksha-platform:fixIconByName Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChakshuGautam ChakshuGautam ChakshuGautam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shubhambawner @ChakshuGautam