Fix CI #433
Merged
Fix CI #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Member
Author
|
I started trying to fix the zarr 2/3 compatability here and it got very messy, I'm confused about how the CI ever passed with zarr 3? |
Member
#427 is my WIP for getting the Zarr 3 tests working again, although it still needs work. Perhaps you can merge this PR as it's an improvement?
There was quite a big change (see #427 (comment)) that broke things here unfortunately. |
Member
Author
|
Ok will merge this leaving the zarr v3 test failing. |
Member
|
Great - I fixed the Zarr v3 tests over in #427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.