Skip to content

Add request-recording stub and request-size assertions to llworldmap_test.cpp#5561

Merged
akleshchev merged 2 commits intoandreyk/5543_pipettefrom
copilot/sub-pr-5560
Mar 23, 2026
Merged

Add request-recording stub and request-size assertions to llworldmap_test.cpp#5561
akleshchev merged 2 commits intoandreyk/5543_pipettefrom
copilot/sub-pr-5560

Conversation

Copy link
Contributor

Copilot AI commented Mar 21, 2026

Addresses reviewer feedback on #5560: the sendMapBlockRequest stub was a no-op, leaving the variable-size rectangle grouping logic (up to 64 regions per request) untested.

Changes

  • Stub now records callssendMapBlockRequest populates a gMapBlockRequests vector (MapBlockRequest struct with min_x/y, max_x/y) instead of silently discarding parameters.

  • New test<4> for updateRegions() – three representative cases:

    Scenario Input Expected
    1×1 block updateRegions(0,0,3,3) 1 request, coords (0,0,3,3), ≤ 64 regions
    2×2 blocks updateRegions(0,0,7,7) 1 request at the 64-region server limit
    4×4 blocks updateRegions(0,0,15,15) 4 requests, each a 4×1-block strip (64 regions), row boundaries verified

Related Issues

  • Please link to a relevant GitHub issue for additional context.
    • Bug Fix: Link to an issue that includes reproduction steps and testing guidance.
    • Feature/Enhancement: Link to an issue with a write-up, rationale, and requirements.

Issue Link: relates to #5560


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

The 4×4-block case specifically exercises the split path: the algorithm can batch at most 4 blocks (64 regions) per request, so a 16-block area must produce exactly 4 requests. Row-boundary assertions (min_y/max_y per request) confirm the strip boundaries are correct.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI changed the title [WIP] [WIP] Address feedback on dynamic map request size adjustments Add request-recording stub and request-size assertions to llworldmap_test.cpp Mar 21, 2026
Copilot AI requested a review from akleshchev March 21, 2026 14:47
@github-actions github-actions bot added the c/cpp label Mar 21, 2026
@akleshchev akleshchev marked this pull request as ready for review March 23, 2026 11:37
@akleshchev akleshchev merged commit 06bf757 into andreyk/5543_pipette Mar 23, 2026
12 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2026
@akleshchev akleshchev deleted the copilot/sub-pr-5560 branch March 23, 2026 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants