Add request-recording stub and request-size assertions to llworldmap_test.cpp#5561
Merged
akleshchev merged 2 commits intoandreyk/5543_pipettefrom Mar 23, 2026
Merged
Add request-recording stub and request-size assertions to llworldmap_test.cpp#5561akleshchev merged 2 commits intoandreyk/5543_pipettefrom
akleshchev merged 2 commits intoandreyk/5543_pipettefrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
…rtions Co-authored-by: akleshchev <117672381+akleshchev@users.noreply.github.com> Agent-Logs-Url: https://github.com/secondlife/viewer/sessions/fb89a385-185d-4179-a3a4-39a45a713f4f
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on dynamic map request size adjustments
Add request-recording stub and request-size assertions to llworldmap_test.cpp
Mar 21, 2026
akleshchev
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses reviewer feedback on #5560: the
sendMapBlockRequeststub was a no-op, leaving the variable-size rectangle grouping logic (up to 64 regions per request) untested.Changes
Stub now records calls –
sendMapBlockRequestpopulates agMapBlockRequestsvector (MapBlockRequeststruct withmin_x/y,max_x/y) instead of silently discarding parameters.New
test<4>forupdateRegions()– three representative cases:updateRegions(0,0,3,3)(0,0,3,3), ≤ 64 regionsupdateRegions(0,0,7,7)updateRegions(0,0,15,15)Related Issues
Issue Link: relates to #5560
Checklist
Please ensure the following before requesting review:
Additional Notes
The 4×4-block case specifically exercises the split path: the algorithm can batch at most 4 blocks (64 regions) per request, so a 16-block area must produce exactly 4 requests. Row-boundary assertions (
min_y/max_yper request) confirm the strip boundaries are correct.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.