Skip to content

#5558 Adjust map request size dynamically#5560

Merged
akleshchev merged 3 commits intodevelopfrom
andreyk/5543_pipette
Mar 24, 2026
Merged

#5558 Adjust map request size dynamically#5560
akleshchev merged 3 commits intodevelopfrom
andreyk/5543_pipette

Conversation

@akleshchev
Copy link
Contributor

@akleshchev akleshchev commented Mar 20, 2026

  • Instead of always requesting 4x4 regions in a single block, adjust request to get up to 64 regions per message (4 blocks)
  • Don't request 'animated' regions, they won't arrive in time.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts world map region loading to reduce unnecessary requests during pan/zoom animation and to better utilize the server’s per-message region limit when requesting map blocks.

Changes:

  • World map view now uses target pan coordinates (mTargetPanX/Y) when determining which regions to request, avoiding short-lived “animated” loads.
  • LLWorldMap::updateRegions now groups contiguous unloaded blocks into variable-size rectangular requests, targeting up to 64 regions per message.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
indra/newview/llworldmapview.cpp Switches visible-block center calculation from animated pan to target pan to avoid transient region requests.
indra/newview/llworldmap.cpp Implements dynamic grouping of unloaded map blocks into larger rectangular requests (up to the server cap).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Animation takes less than a second, regions take over a second to load.
Don't request transitionarry regions, got for target.
Copy link
Contributor

Copilot AI commented Mar 21, 2026

@akleshchev I've opened a new pull request, #5561, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (akleshchev)[https://github.com/akleshchev]
@copilot
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@akleshchev akleshchev merged commit b7fc5b2 into develop Mar 24, 2026
14 of 16 checks passed
@akleshchev akleshchev deleted the andreyk/5543_pipette branch March 24, 2026 00:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The viewer sends many more MapBlockRequest when viewing World Map than it needs to

4 participants