feat: Add a setting to disallow hard-coding some setting keys in the pyproject.toml
#1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
force-pushed
the
feat/no-hardcode-opts
branch
from
a2504cc to
9922ae6
Compare
LecrisUT
force-pushed
the
feat/no-hardcode-opts
branch
3 times, most recently
from
9a77549 to
417a6e7
Compare
Used for further validations Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Add `test_disallow_hardcoded` to cover these type of settings Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
feat/no-hardcode-opts
branch
from
417a6e7 to
bbc3671
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
feat/no-hardcode-opts
branch
from
53aed69 to
f1a073a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements the discussion in #1050 that we should not allow some fields to be hard-coded. We should allow them in the context of overrides, so here is a rather convoluted way of adding that check.
This will also make it possible to extend it further if we want more specific checks for specific overrides matchers as well. E.g. we can add a restriction that
build.requirescannot have@in ansdist