feat: Better support for cross-compilation #1050
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Python_ROOT_DIR` is used for the find hints for - `Python_EXECUTABLE`: Unnecessary because we provide `Python_EXECUTABLE` as a cache variable and that has precedence - `python-config`: should point to the target's variable. Generally this is a shell script which would be executable during cross-compilation (windows case unknown) - `Python_LIBRARY`: should point to the target's library which would be on the `crossenv` uses a fake environment so that `sys.base_*_prefix` variables point to the target's system. Presumably PEP720 would work the same. Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
feat/cross-compile
branch
from
1acc621 to
3e906b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly the cross-compilation works out-of-the-box with
crossenv+CMAKE_TOOLCHAIN_FILE. There is only one adjustment needed forPython_ROOT_DIRto point tosys.base_exec_prefix, the rest is documentation of the change and adding support forCMAKE_TOOLCHAIN_FILEwhere needed.I presume that under PEP720 the same workflow will be valid, primarily
sys.base_exec_prefixwould point to the target's implementation, otherwise the document should be clarified on what to expect. I have raised the issue for further clarification 1Footnotes
https://discuss.python.org/t/pep-720-cross-compiling-python-packages/29988/2 ↩