Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround bug where rails does not 'require' logger #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Workaround bug where rails does not 'require' logger #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/kithe.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@
# we can stop require'ing it here, it's just a weird workaround.
require 'yell'


# bug in Rails pre-7.0 requires us to manually 'require' logger dep, Rails isn't going
# to release a fix. https://github.com/rails/rails/pull/54264
#
# Tried to do this conditionally only if Rails < 7.1, but hard with order of
# dependency loading. This is fine.
require 'logger'

module Kithe
# for ruby-progressbar
STANDARD_PROGRESS_BAR_FORMAT = "%a %t: |%B| %R/s %c/%u %p%% %e"
Expand Down
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# it.
#
# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
#

require 'byebug'
require 'webmock/rspec'
require 'db_query_matchers'
Expand Down
Loading