Workaround bug where rails does not 'require' logger #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrochkind
force-pushed
the
workaround_rails_logger_req_bug
branch
from
8f19399 to
430caa7
Compare
Logger got moved to default gems a while ago in ruby versions, and rails should have been 'require'ing it but wasn't. This was hidden by the fact that concurrent-ruby used to 'require' it, but no longer does. With recent versions of concurrent-ruby, somebody needs to 'require' logger -- Rails does not plan to release a fix for pre-7.1 rails. So we can simply require it in our spec_helper for CI no big deal.
jrochkind
force-pushed
the
workaround_rails_logger_req_bug
branch
from
430caa7 to
50fbb75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger got moved to default gems a while ago in ruby versions, and rails should have been 'require'ing it but wasn't. This was hidden by the fact that concurrent-ruby used to 'require' it, but no longer does. With recent versions of concurrent-ruby, somebody needs to 'require' logger -- Rails does not plan to release a fix for pre-7.1 rails.
So we can simply require it in our spec_helper for CI no big deal.