CaloValid - O+O Update #4145
Merged
CaloValid - O+O Update #4145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated downscale factors for the calorimeters and mbd by the ratio of nucleons: OO / AuAu - Add "OO" as a m_species option - Updated RunnumberRange to place temporary first and last for OO as well as update the last runnumber for proton+proton.
Contributor
📝 WalkthroughWalkthroughThis pull request introduces support for Run-3 Oxygen-Oxygen (O+O) collisions by defining new run number ranges in the run range header and implementing OO-specific detector calibration and downscaling parameters in the calorimeter validation code. Changes
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds support for Run-3 Oxygen+Oxygen (O+O) collisions in the calorimeter validation framework by implementing run number ranges and appropriate downscale factors.
Changes:
- Updated
RUN3PP_LASTfrom placeholder (100000) to actual value (81668) - Added
RUN3OOrun number range constants with temporary placeholder values - Added O+O species detection in
CaloValid::InitRun()based on run number ranges - Implemented calorimeter and MBD downscale factors for O+O scaled by nucleon ratio (16/197 relative to Au+Au)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| offline/framework/phool/RunnumberRange.h | Defines run number ranges: updated PP endpoint and added temporary OO range constants |
| offline/QA/Calorimeters/CaloValid.cc | Adds OO species detection logic and calculates appropriate downscale factors using nucleon ratio scaling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Build & test reportReport for commit 918880db72cf231d36fa2d565849075c4353c76d:
Automatically generated by sPHENIX Jenkins continuous integration |
Contributor
|
clang-tidy fail is from adding the OO run range in RunumberRange.h |
Contributor
|
Note Docstrings generation - SUCCESS |
pinkenburg
merged commit 373f714
into
sPHENIX-Collaboration:master
24 of 28 checks passed
coderabbitai bot
added a commit
that referenced
this pull request
Jan 29, 2026
Docstrings generation was requested by @pinkenburg. * #4145 (comment) The following files were modified: * `offline/QA/Calorimeters/CaloValid.cc` * `offline/framework/phool/RunnumberRange.h`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)