RunnumberRange - O+O #4172
Merged
RunnumberRange - O+O #4172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the first and last runnumbers for Run 3 O+O.
Contributor
📝 WalkthroughWalkthroughUpdates two run number constants in the RunnumberRange header to reflect finalized Run 3 O+O physics run ranges. RUN3OO_FIRST changes from 82300 to 82374; RUN3OO_LAST changes from 200000 to 82703. Documentation updated accordingly. Changes
Possibly related PRs
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the canonical Run 3 O+O run-number range constants in RunnumberRange.h, which are used across the offline framework (e.g., for collision-species selection logic).
Changes:
- Replace the temporary placeholder O+O run range with finalized first/last run numbers for Run 3 O+O.
- Update the header documentation to remove “temporary placeholder” wording for O+O.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Merging this now to get it into the ana build (it's just an update for the first and last OO run) |
pinkenburg
merged commit bd4fc9e
into
sPHENIX-Collaboration:master
24 of 26 checks passed
Build & test reportReport for commit 494b21b830d682437c6ccc3e7a1a878be097844c:
Automatically generated by sPHENIX Jenkins continuous integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Run 3 O+O Run Number Range Update
Motivation & Context
This PR corrects the run number range constants for Run 3 Oxygen+Oxygen (O+O) collisions in the sPHENIX experiment's core software framework. These constants are used throughout the reconstruction and QA framework to identify and classify O+O physics data. The previous placeholder values (RUN3OO_FIRST = 82300, RUN3OO_LAST = 200000) have been replaced with the actual physics run boundaries determined from the experimental run log.
Key Changes
Potential Risk Areas
offline/QA/Calorimeters/CaloValid.ccwhere it determines run classification for species-specific QA histograms ("OO" identifier). Runs 82300–82373 previously tagged as O+O will now default to pp classification; affected QA plots should be regenerated.Recommendations
AI-generated content disclaimer: This summary is based on AI analysis of code changes and may contain errors. Please apply best judgment when reviewing the impact—verify the corrected run numbers match your experiment's official run log and validate affected QA/reconstruction code against real O+O data before deploying to production.