Mark some set_* fns as potentially throwing. #2852
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make attributes marked `[SetterThrows]` use a `set_*` function that returns a `Result`. Currently webidl only looks for a `[Throws]` attribute.
richard-uk1
force-pushed
the
SetterThrows
branch
from
cd9da69 to
7355acf
Compare
|
Ready for review |
Merged
|
This naively looks like a breaking change which is something I don't want to commit to. Is there a reason though that this won't be an issue in practice? |
|
It is a breaking change, but currently the generated code is incorrect
(some attribute setters can throw and agent caught by web_sys). Do you
allow breaking changes to correct errors?
…On Tue, 5 Apr 2022, 15:55 Alex Crichton, ***@***.***> wrote:
This naively looks like a breaking change which is something I don't want
to commit to. Is there a reason though that this won't be an issue in
practice?
—
Reply to this email directly, view it on GitHub
<#2852 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKT4XQVOPVPO2JB4X4R2XLVDRH55ANCNFSM5SPYL6DQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Sorry I'm not merging breaking changes at this time because I'm not personally prepared to deal with the fallout. I wish I had a better answer for you but I do not at this time. |
|
Ok no worries shall I leave the pr open?
…On Wed, 6 Apr 2022, 16:42 Alex Crichton, ***@***.***> wrote:
Sorry I'm not merging breaking changes at this time because I'm not
personally prepared to deal with the fallout. I wish I had a better answer
for you but I do not at this time.
—
Reply to this email directly, view it on GitHub
<#2852 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKT4XSYVRIO2XBC4W4X3FDVDWWGZANCNFSM5SPYL6DQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Liamolucko
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make attributes marked
[SetterThrows]use aset_*function that returns aResult. Currently webidl only looks for a[Throws]attribute.I found this problem while writing an indexed DB wrapper. The function
web_sys::IdbObjectStore::set_nameshould return aResult, because setting the name can go wrong in a number of ways. When I looked at the IDL files, the attribute had a[SetterThrows]mark rather than the more general[Throws].